Merge lp:~sil2100/dbus-cpp/fix_ftbfs_gtest into lp:dbus-cpp

Proposed by Łukasz Zemczak
Status: Needs review
Proposed branch: lp:~sil2100/dbus-cpp/fix_ftbfs_gtest
Merge into: lp:dbus-cpp
Diff against target: 31 lines (+3/-7)
2 files modified
debian/control (+1/-0)
tests/CMakeLists.txt (+2/-7)
To merge this branch: bzr merge lp:~sil2100/dbus-cpp/fix_ftbfs_gtest
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+322129@code.launchpad.net

Commit message

Switch to using cmake-extras for the gmock and gtest bits.

Description of the change

Switch to using cmake-extras for the gmock and gtest bits.

To post a comment you must log in.

Unmerged revisions

104. By Łukasz Zemczak

Switch to using cmake-extras for the gmock and gtest bits.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-08-09 07:31:30 +0000
3+++ debian/control 2017-04-06 16:40:08 +0000
4@@ -7,6 +7,7 @@
5 Priority: optional
6 Maintainer: Thomas Voß <thomas.voss@ubuntu.com>
7 Build-Depends: cmake,
8+ cmake-extras,
9 dbus,
10 debhelper (>= 9),
11 doxygen,
12
13=== modified file 'tests/CMakeLists.txt'
14--- tests/CMakeLists.txt 2014-09-28 21:27:09 +0000
15+++ tests/CMakeLists.txt 2017-04-06 16:40:08 +0000
16@@ -15,13 +15,8 @@
17 # Authored by: Thomas Voss <thomas.voss@canonical.com>
18
19 # Build with system gmock and embedded gtest
20-set (GMOCK_INCLUDE_DIR "/usr/include/gmock/include" CACHE PATH "gmock source include directory")
21-set (GMOCK_SOURCE_DIR "/usr/src/gmock" CACHE PATH "gmock source directory")
22-set (GTEST_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/gtest/include" CACHE PATH "gtest source include directory")
23-
24-add_subdirectory(${GMOCK_SOURCE_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock")
25-
26-set(GTEST_BOTH_LIBRARIES gmock gtest gtest_main)
27+find_package(GMock)
28+
29 find_package(Threads)
30
31 add_definitions(-DCORE_DBUS_ENABLE_GOOGLE_TEST_FIXTURE)

Subscribers

People subscribed via source and target branches