Merge lp:~sil2100/cupstream2distro-config/stack_package_dependency_additions into lp:cupstream2distro-config

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 203
Merged at revision: 211
Proposed branch: lp:~sil2100/cupstream2distro-config/stack_package_dependency_additions
Merge into: lp:cupstream2distro-config
Diff against target: 51 lines (+4/-4)
4 files modified
stacks/head/apps.cfg (+1/-1)
stacks/head/hud.cfg (+1/-1)
stacks/head/media.cfg (+1/-1)
stacks/head/phone.cfg (+1/-1)
To merge this branch: bzr merge lp:~sil2100/cupstream2distro-config/stack_package_dependency_additions
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+159110@code.launchpad.net

Commit message

Add the explicit list of packages to be installed for testing, which are depenencies of the actual packages under test in the of stacks: apps, hud, phone, media. This is because we cannot auto-fetch dependencies because of known reasons

Description of the change

- Problem:

The jenkins stack test jobs are failing due to extra packages being installed as pulled in as dependencies of the main packages from the tests_parameters packages section. As explained by Didier, we cannot allow auto-pulling of deps, as this might result in problems in certain cases.

- Fix:

For now we decided that we will be manually writing down the package names that are being pulled additionally. I'm doing this for a few stacks that had been obviously failing because of that.
Now, qt5 deps are necessary. The xcb libs also seem currently necessary, as these are required for the xcb platform plugin that we use in Ubuntu Qt5. *sphinx* and julius* deps are from HUD, which is being used extensively in every stack. libavcodec53 and all those dependencies for codecs are seemingly required by the mediaplayer-app, which pulls all those deps through gstreamer0.10-ffmpeg. We also do not include the mysql requirements of webbrowser-app (invalidly pulled in by libqt5sql5) in the app stack, as this needs to be fixed in Qt5 (separate patch ready).

As requested, for easy removal of all those deps, I always set the libqt5core5 dep as the last one of the 'extra' deps, so that it can be easily distinguished when the extra deps are ending and the real test packages start.

- Tests:

N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking mostly good, thanks for the hard work Lukasz!

However, we need a way to remove gstreamer0.10-ffmpeg from the list of dependency. It's not in main but universe and the license of ffmepg makes it incompatible for us to ship it by default in the future. Is there any way to (even if we support less videos format for now on), plug anything gstreamer codec? (the -good ones we are installing by default for instance?)

review: Needs Fixing
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

approving then after the discussion. Putting a big red note though :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stacks/head/apps.cfg'
2--- stacks/head/apps.cfg 2013-04-15 22:22:48 +0000
3+++ stacks/head/apps.cfg 2013-04-16 09:19:26 +0000
4@@ -10,7 +10,7 @@
5 - sdk
6 - hud
7 test_parameters:
8- packages: gallery-app webbrowser-app
9+ packages: libqt5sql5-sqlite julius julius-voxforge libhud-client2 libhud-qt libhud-qt-qml libhud1 libpocketsphinx1 libqt53d5 libqt5dbus5 libqt5graphicaleffects5 libqt5gui5 libqt5location5 libqt5network5 libqt5opengl5 libqt5printsupport5 libqt5qml5 libqt5quick5 libqt5sensors5 libqt5sql5 libqt5svg5 libqt5v8-5 libqt5webkit5 libqt5webkit5-qmlwebkitplugin libqt5widgets5 libsphinxbase1 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-sync0 pocketsphinx-hmm-en-hub4wsj pocketsphinx-lm-en-hub4 pocketsphinx-utils qtdeclarative5-qtquick2-plugin qtdeclarative5-ubuntu-ui-toolkit-plugin qtdeclarative5-window-plugin ubuntu-ui-toolkit-theme libqt5core5 gallery-app webbrowser-app
10 testpackages: gallery-app-autopilot webbrowser-app-autopilot
11 tests: gallery_app webbrowser_app
12 ci_default:
13
14=== modified file 'stacks/head/hud.cfg'
15--- stacks/head/hud.cfg 2013-04-10 22:03:12 +0000
16+++ stacks/head/hud.cfg 2013-04-16 09:19:26 +0000
17@@ -20,7 +20,7 @@
18 contact_email: allan.lesage@canonical.com
19 use_description_for_commit: True
20 test_parameters:
21- packages: hud libhud-qt libhud-qt-qml
22+ packages: julius julius-voxforge libhud-client2 libhud1 libpocketsphinx1 libqt5dbus5 libqt5gui5 libqt5network5 libqt5qml5 libqt5v8-5 libsphinxbase1 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-sync0 pocketsphinx-hmm-en-hub4wsj pocketsphinx-lm-en-hub4 pocketsphinx-utils libqt5core5 hud libhud-qt libhud-qt-qml
23 testpackages: unity-autopilot
24 tests: unity.tests.test_hud unity.tests.test_search.HudSearchTests unity.tests.test_search.HudFuzzySearchTests
25 projects:
26
27=== modified file 'stacks/head/media.cfg'
28--- stacks/head/media.cfg 2013-04-16 02:02:36 +0000
29+++ stacks/head/media.cfg 2013-04-16 09:19:26 +0000
30@@ -11,7 +11,7 @@
31 - qa
32 - sdk
33 test_parameters:
34- packages: mediaplayer-app
35+ packages: gstreamer0.10-ffmpeg hud julius julius-voxforge libavcodec53 libavformat53 libavutil51 libgsm1 libhud-client2 libhud-qt libhud-qt-qml libhud1 libpocketsphinx1 libpostproc52 libqgsttools-p1 libqt5dbus5 libqt5graphicaleffects5 libqt5gui5 libqt5multimedia5 libqt5multimediaquick-p5 libqt5network5 libqt5qml5 libqt5quick5 libqt5svg5 libqt5v8-5 libqt5widgets5 libqt5xmlpatterns5 libschroedinger-1.0-0 libsphinxbase1 libswscale2 libva1 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-sync0 pocketsphinx-hmm-en-hub4wsj pocketsphinx-lm-en-hub4 pocketsphinx-utils qtdeclarative5-qtmultimedia-plugin qtdeclarative5-qtquick2-plugin qtdeclarative5-ubuntu-ui-toolkit-plugin qtdeclarative5-window-plugin qtdeclarative5-xmllistmodel-plugin ubuntu-ui-toolkit-theme libqt5core5 mediaplayer-app
36 testpackages: mediaplayer-app-autopilot
37 tests: mediaplayer_app
38 ci_default:
39
40=== modified file 'stacks/head/phone.cfg'
41--- stacks/head/phone.cfg 2013-04-15 22:06:24 +0000
42+++ stacks/head/phone.cfg 2013-04-16 09:19:26 +0000
43@@ -12,7 +12,7 @@
44 - hud
45 - sdk
46 test_parameters:
47- packages: phone-app
48+ packages: hud julius julius-voxforge libhud-client2 libhud-qt libhud-qt-qml libhud1 libpocketsphinx1 libqgsttools-p1 libqt5contacts5 libqt5dbus5 libqt5graphicaleffects5 libqt5gui5 libqt5multimedia5 libqt5network5 libqt5qml5 libqt5quick5 libqt5svg5 libqt5v8-5 libqt5versit5 libqt5widgets5 libqt5xml5 libqtglib-2.0-0 libsphinxbase1 libtelepathy-logger-qt5-0 libtelepathy-qt5-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 libxcb-sync0 ofono pocketsphinx-hmm-en-hub4wsj pocketsphinx-lm-en-hub4 pocketsphinx-utils python-telepathy qtdeclarative5-qtquick2-plugin qtdeclarative5-ubuntu-ui-toolkit-plugin telepathy-ofono ubuntu-ui-toolkit-theme libqt5core5 phone-app
49 testpackages: phone-app-autopilot
50 tests: phone_app
51 ci_default:

Subscribers

People subscribed via source and target branches

to all changes: