Merge lp:~sil2100/content-hub/packaging_review into lp:~content-hub-team/content-hub/trunk

[Łukasz Zemczak]

Packaging review

Packaging review, work in progress.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:12
http://jenkins.qa.ubuntu.com/job/content-hub-ci/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-amd64-ci/20/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/20/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-i386-ci/20/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/content-hub-ci/20/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

Thanks, did you manage to build it? it complains about missing directores here (acceptance_tests, services)

> qtdeclarative5-content-hub-0.0

that should be "hub0.0" without the "-" ... in fact the code is "import Ubuntu.Content 0.1", shouldn't it be named "qtdeclarative5-ubuntu-content0.1"?

review: Needs Fixing

[lp:~sil2100/content-hub/packaging_review]

13. By Łukasz Zemczak on 2013-08-23

Changed the plugin name

14. By Łukasz Zemczak on 2013-08-23

Rename the plugin again

15. By Łukasz Zemczak on 2013-08-23

.install file too...

[Sebastien Bacher (seb128)]

looks good, thanks

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:14
http://jenkins.qa.ubuntu.com/job/content-hub-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/21/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-i386-ci/21

Click here to trigger a rebuild:
http://s-jenkins:8080/job/content-hub-ci/21/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:15
http://jenkins.qa.ubuntu.com/job/content-hub-ci/22/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-saucy-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins:8080/job/content-hub-ci/22/rebuild

review: Approve (continuous-integration)

[Ken VanDine (ken-vandine)]

Looks good

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2013-08-13 13:20:55 +0000
+++ debian/changelog	2013-08-23 11:49:27 +0000
@@ -1,5 +1,9 @@
 content-hub (0.0-0ubuntu1) UNRELEASED; urgency=low
 
+  [ Ken VanDine ]
   * Initial package
 
+  [ Łukasz 'sil2100' Zemczak ]
+  * Automatic snapshot from revision 10 (bootstrap)
+
  -- Ken VanDine <[e-mail]>  Mon, 12 Aug 2013 15:51:35 -0400

=== modified file 'debian/control'
--- debian/control	2013-08-22 14:15:27 +0000
+++ debian/control	2013-08-23 11:49:27 +0000
@@ -1,5 +1,5 @@
 Source: content-hub
-Priority: extra
+Priority: optional
 Maintainer: Ken VanDine <[e-mail]>
 Build-Depends: cmake,
                debhelper (>= 9),
@@ -15,32 +15,44 @@
 Standards-Version: 3.9.4
 Section: libs
 Homepage: https://launchpad.net/content-hub
+# If you aren't a member of ~phablet-team but need to upload packaging changes,
+# just go ahead. ~phablet-team will notice and sync up the code again.
+Vcs-Bzr: https://code.launchpad.net/~phablet-team/content-hub/trunk
+Vcs-Browser: https://bazaar.launchpad.net/~phablet-team/content-hub/trunk/files
 
 Package: content-hub
 Architecture: any
 Depends: ${misc:Depends},
          ${shlibs:Depends},
-Description: <insert up to 60 chars description>
- <insert long description, indented with spaces>
+Description: content sharing/picking service
+ Content sharing/picking infrastructure and service, designed to allow apps to
+ securely and efficiently exchange content.
+ This package includes the content sharing service.
+
+Package: libcontent-hub0
+Section: libs
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends},
+         ${shlibs:Depends},
+Description: content sharing/picking library
+ Content sharing/picking infrastructure and service, designed to allow apps to
+ securely and efficiently exchange content.
+ This package includes the content sharing libraries.
 
 Package: libcontent-hub-dev
 Section: libdevel
 Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends},
          ${shlibs:Depends},
          libcontent-hub0 (= ${binary:Version}),
-Description: <insert up to 60 chars description>
- <insert long description, indented with spaces>
-
-Package: libcontent-hub0
-Section: libs
-Architecture: any
-Depends: ${misc:Depends},
-         ${shlibs:Depends},
-Description: <insert up to 60 chars description>
- <insert long description, indented with spaces>
-
-Package: qtdeclarative5-content-hub-plugin
+Description: content sharing development files
+ All the development headers and libraries for the content hub
+
+Package: qtdeclarative5-ubuntu-content0.1
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends},
@@ -54,5 +66,6 @@
 Section: doc
 Architecture: all
 Depends: ${misc:Depends},
-Description: <insert up to 60 chars description>
- <insert long description, indented with spaces>
+         libcontent-hub-dev (>= ${source:Version}),
+Description: Documentation files for libcontent-hub-dev
+ Documentation files for the libcontent-hub development

=== modified file 'debian/copyright'
--- debian/copyright	2013-08-13 13:20:55 +0000
+++ debian/copyright	2013-08-23 11:49:27 +0000
@@ -19,4 +19,22 @@
  along with this program. If not, see <http://www.gnu.org/licenses/>.
  .
  On Debian systems, the complete text of the GNU Lesser General
- Public License can be found in "/usr/share/common-licenses/LGPL-3".
+ Public License can be found in /usr/share/common-licenses/LGPL-3.
+
+Files: src/com/ubuntu/content/service/* tests/acceptance-tests/*
+Copyright: 2013 Canonical Ltd.
+License: GPL-3.0
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, version 3 of the License.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the full text of the GNU General Public License
+ version 3 can be found in the file /usr/share/common-licenses/GPL-3.

=== modified file 'debian/libcontent-hub-dev.install'
--- debian/libcontent-hub-dev.install	2013-08-21 12:08:58 +0000
+++ debian/libcontent-hub-dev.install	2013-08-23 11:49:27 +0000
@@ -1,1 +1,2 @@
+usr/lib/*/libcontent-hub.so
 usr/include

=== modified file 'debian/libcontent-hub0.install'
--- debian/libcontent-hub0.install	2013-08-22 12:21:17 +0000
+++ debian/libcontent-hub0.install	2013-08-23 11:49:27 +0000
@@ -1,2 +1,2 @@
-usr/lib/*/lib*.so*
+usr/lib/*/lib*.so.*
 

=== renamed file 'debian/qtdeclarative5-content-hub-plugin.install' => 'debian/qtdeclarative5-ubuntu-content0.1.install'
=== modified file 'debian/rules'
--- debian/rules	2013-08-13 13:20:55 +0000
+++ debian/rules	2013-08-23 11:49:27 +0000
@@ -4,8 +4,10 @@
 # Uncomment this to turn on verbose mode.
 #export DH_VERBOSE=1
 
+export DPKG_GENSYMBOLS_CHECK_LEVEL=4
+
 %:
-	dh $@ -- -B build 
+	dh $@ --fail-missing -- -B build 
 
 override_dh_auto_test:
 	dbus-test-runner -t make -p "-C" -p "build" -p test