Code review comment for lp:~sil2100/compiz/revert_3427_0.9.8

See: https://www.virtualbox.org/ticket/10894

They didn't specify which revision the fix went in though, but they did say
which release.
On Jan 25, 2013 7:19 AM, "Sam Spilsbury" <email address hidden> wrote:

> I would suggest updating virtual box instead. They told me they've fixed
> the bug on their end.
>
> Putting this fix in will likely regress the crash with llvmpipe.
> On 25/01/2013 3:17 AM, "Łukasz Zemczak" <email address hidden>
> wrote:
>
> > Łukasz Zemczak has proposed merging lp:~sil2100/compiz/revert_3427_0.9.8
> > into lp:compiz/0.9.8.
> >
> > Commit message:
> > Revert revision 3427 - it seems to cause regressions on VirtualBox for
> > quantal.
> >
> > Requested reviews:
> > Compiz Maintainers (compiz-team)
> >
> > For more details, see:
> >
> https://code.launchpad.net/~sil2100/compiz/revert_3427_0.9.8/+merge/144764
> >
> > - Problem:
> >
> > The current 0.9.8 snapshot branch causes crashes and hangups on
> > VirtualBox. Francis bisected it to be caused by fix of LP: #1060327 .
> >
> > - Fix:
> >
> > Reverting revision 3427 (fix for LP: #1060327). It is said to be fixing
> > the regressions.
> >
> > - Tests:
> >
> > N/A
> > --
> >
> https://code.launchpad.net/~sil2100/compiz/revert_3427_0.9.8/+merge/144764
> > Your team Compiz Maintainers is requested to review the proposed merge of
> > lp:~sil2100/compiz/revert_3427_0.9.8 into lp:compiz/0.9.8.
> >
> > === modified file 'plugins/opengl/src/glxtfpbind/src/glx-tfp-bind.cpp'
> > --- plugins/opengl/src/glxtfpbind/src/glx-tfp-bind.cpp 2012-12-11
> > 04:53:02 +0000
> > +++ plugins/opengl/src/glxtfpbind/src/glx-tfp-bind.cpp 2013-01-24
> > 18:16:22 +0000
> > @@ -52,12 +52,6 @@
> > #endif
> > if (!checkPixmapValidity (x11Pixmap))
> > return false;
> > -
> > -#ifdef LP_1030891_NOT_FIXED
> > - // We need to bind before the above ServerLock is lost
> > - bindTexImageEXT (glxPixmap);
> > - return true;
> > -#endif
> > }
> >
> > bindTexImageEXT (glxPixmap);
> >
> >
> >
>
> --
> https://code.launchpad.net/~sil2100/compiz/revert_3427_0.9.8/+merge/144764
> Your team Compiz Maintainers is requested to review the proposed merge of
> lp:~sil2100/compiz/revert_3427_0.9.8 into lp:compiz/0.9.8.
>