Compiz

Merge lp:~sil2100/compiz/fix_python_find_package into lp:compiz/0.9.9

  1. fix_python_find_package
  2. Merge into 0.9.9
Proposed by Łukasz Zemczak
Status: Merged
Approved by: Daniel van Vugt
Approved revision: 3523
Merged at revision: 3524
Proposed branch: lp:~sil2100/compiz/fix_python_find_package
Merge into: lp:compiz/0.9.9
Diff against target: 13 lines (+2/-1)
1 file modified
compizconfig/compizconfig-python/CMakeLists.txt (+2/-1)
To merge this branch: bzr merge lp:~sil2100/compiz/fix_python_find_package
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Daniel van Vugt Approve
Review via email: mp+139256@code.launchpad.net

Commit message

Change to pkg_check_modules instead of find_package to find python-related
includes in multi-arch.
(LP: #1088996)

Description of the change

- Problem:

Compiz FTBFS after the latest python package upgrade. The problem seems to be in the pyconfig.h file moved to a multi-arch directory, which is not supported by find_package().

- Fix:

Use pkg_check_modules() instead find_package().

- Tests:

N/A

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Waiting for https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/1088988 to be resolved.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

It is now in, Lukasz, please restest with it :)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It looks right, providing Jenkins agrees.

I'm not sure we need to impose 2.7 as a requirement right now but it probably won't hurt.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3523
http://jenkins.qa.ubuntu.com/job/compiz-ci/322/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-ci/./build=pbuilder,distribution=quantal,flavor=amd64/322/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/compiz-ci/322//rebuild/?

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'compizconfig/compizconfig-python/CMakeLists.txt'
2--- compizconfig/compizconfig-python/CMakeLists.txt 2012-12-04 15:22:23 +0000
3+++ compizconfig/compizconfig-python/CMakeLists.txt 2012-12-11 16:37:28 +0000
4@@ -8,7 +8,8 @@
5 execute_process (COMMAND python -c "import sys; print str (sys.version_info[0]) + '.' + str (sys.version_info[1])"
6 OUTPUT_VARIABLE PY_VERSION)
7
8-find_package (PythonLibs)
9+include (FindPkgConfig)
10+pkg_check_modules (PYTHON python-2.7)
11
12 # This is a workaround for a broken FindPythonLibs always finding the
13 # wrong library version because PYTHON_LIBRARY is in the cache and

Subscribers

People subscribed via source and target branches