Code review comment for ~sil2100/cloud-initramfs-tools:growroot-do-not-waitroot
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
well, lots of things have changed since this code was written and it probably did take a safe approach even then. Generally speaking, one 'settle' or (wait-for-root) immediately after another is going to happen "real fast", so its not really wasteful.
In theory, we've worked out all the bugs in growpart at cloud-utils version 0.32, and there is no longer any need for *any* settle as growpart should not return until everything has been done. (see 6b98f49ffb2c7, 957ba4cff0, d99b2d7664d5).
that might be something to consider.
I won't approve or deny this, simply because I don't really have the time to think it all the way through. I'll let someone else do that.