Merge lp:~sil2100/appmenu-qt/disable_qt5 into lp:appmenu-qt

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 59
Merged at revision: 59
Proposed branch: lp:~sil2100/appmenu-qt/disable_qt5
Merge into: lp:appmenu-qt
Diff against target: 78 lines (+3/-39)
2 files modified
debian/control (+2/-19)
debian/rules (+1/-20)
To merge this branch: bzr merge lp:~sil2100/appmenu-qt/disable_qt5
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+201931@code.launchpad.net

Commit message

Remove the appmenu-qt5 packages - those are now built using the new appmenu-qt5 sources, using QPA and upstream Qt5 approaches to global menus

Description of the change

Remove the appmenu-qt5 packages - those are now built using the new appmenu-qt5 sources, using QPA and upstream Qt5 approaches to global menus

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good, and the new appmenu-qt5 builds already.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-05-02 15:24:55 +0000
3+++ debian/control 2014-01-16 14:06:21 +0000
4@@ -1,17 +1,15 @@
5 Source: appmenu-qt
6 Section: kde
7-Priority: extra
8+Priority: optional
9 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
10 XSBC-Original-Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
11 Uploaders: Ritesh Raj Sarraf <rrs@debian.org>,
12 Build-Depends: cmake,
13 debhelper (>= 9),
14 libdbusmenu-qt-dev,
15- libdbusmenu-qt5-dev,
16 libqt4-dev (>= 4:4.8),
17 pkg-config,
18- qtbase5-dev (>= 5.0.1+dfsg-0ubuntu4~),
19-Standards-Version: 3.9.3
20+Standards-Version: 3.9.5
21 Homepage: https://launchpad.net/appmenu-qt
22 # If you aren't ~indicator-applet-developers but need to upload packaging changes,
23 # just go ahead. ~indicator-applet-developers will notice and sync up the code again.
24@@ -27,18 +25,3 @@
25 global menu bar
26 .
27 appmenu-qt will work for applications designed for Qt and KDE
28-
29-Package: appmenu-qt5
30-Architecture: any
31-Depends: ${misc:Depends},
32- ${shlibs:Depends},
33-Suggests: libqt5core5,
34- libqt5dbus5,
35- libqt5gui5,
36- libqt5widgets5,
37-Description: application menu for Qt5
38- appmenu provides you with an integrated application menu in your
39- global menu bar
40- .
41- appmenu-qt5 will work for applications designed for Qt and KDE
42- This is the Qt5 version
43
44=== modified file 'debian/rules'
45--- debian/rules 2013-03-28 14:26:55 +0000
46+++ debian/rules 2014-01-16 14:06:21 +0000
47@@ -8,18 +8,7 @@
48 dh $@
49
50 override_dh_auto_configure:
51- mkdir qt4
52- mkdir qt5
53- cd qt4 && QT_SELECT=qt4 cmake -DUSE_QT4=true ../
54- cd qt5 && QT_SELECT=qt5 cmake -DUSE_QT5=true ../
55-
56-override_dh_auto_build:
57- cd qt4 && make
58- cd qt5 && make
59-
60-override_dh_auto_install:
61- cd qt4 && make DESTDIR=../debian/appmenu-qt install
62- cd qt5 && make DESTDIR=../debian/appmenu-qt5 install
63+ QT_SELECT=qt4 cmake -DUSE_QT4=true
64
65 override_dh_installchangelogs:
66 dh_installchangelogs NEWS
67@@ -29,11 +18,3 @@
68
69 override_dh_install:
70 dh_install --fail-missing
71-
72-override_dh_gencontrol:
73- # Ugly hack, since we don't want to have Qt5 as our depends, we prefer
74- # those as Suggests for now
75- sed -i '/^shlibs/s/libqt5[^,]*, //g' debian/appmenu-qt5.substvars
76- sed -i '/^shlibs/s/,[^,]* libqt5.*$$//' debian/appmenu-qt5.substvars
77-
78- dh_gencontrol

Subscribers

People subscribed via source and target branches