Merge lp:~sil/rhythmbox-ubuntuone/fix-mp3-install into lp:~sil/rhythmbox-ubuntuone/trunk

Proposed by Stuart Langridge
Status: Merged
Merged at revision: not available
Proposed branch: lp:~sil/rhythmbox-ubuntuone/fix-mp3-install
Merge into: lp:~sil/rhythmbox-ubuntuone/trunk
Diff against target: 42 lines (+4/-7)
1 file modified
umusicstore/__init__.py (+4/-7)
To merge this branch: bzr merge lp:~sil/rhythmbox-ubuntuone/fix-mp3-install
Reviewer Review Type Date Requested Status
Guillermo Gonzalez (community) Approve
Stuart Langridge Pending
Review via email: mp+20458@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stuart Langridge (sil) wrote :

Fix the mp3-codec installer, which I broke, doh.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'umusicstore/__init__.py'
2--- umusicstore/__init__.py 2010-02-22 16:23:36 +0000
3+++ umusicstore/__init__.py 2010-03-02 16:17:15 +0000
4@@ -150,9 +150,6 @@
5 """Source startup."""
6 if self.__activated: return
7 self.__activated = True
8- self.body = gtk.EventBox()
9- self.pack_start(self.body)
10- self.body.show_all()
11 self.test_can_play_mp3()
12 rb.Source.do_impl_activate (self)
13
14@@ -210,7 +207,7 @@
15 self.install_vbox.pack_start(self.install_hbtn, expand=False)
16 self.install_box.add(self.install_vbox)
17 self.install_box.show_all()
18- self.body.add_with_viewport(self.install_box)
19+ self.add(self.install_box)
20
21 def _start_mp3_install(self, btn):
22 ac = aptdaemon.client.AptClient()
23@@ -233,7 +230,7 @@
24 def _finished(self, trans, exit_code):
25 """Aptdaemon package installation finished; show music store."""
26 if exit_code == 0:
27- self.body.remove(self.install_box.get_parent())
28+ self.remove(self.install_box)
29 gst.update_registry()
30 self.add_music_store_widget()
31 else:
32@@ -255,8 +252,8 @@
33 def add_music_store_widget(self):
34 """Display the music store widget in Rhythmbox."""
35 self.browser = U1MusicStore()
36- self.body.add(self.browser)
37- self.body.show_all()
38+ self.add(self.browser)
39+ self.show_all()
40 self.browser.set_no_show_all(True)
41 self.browser.set_property("visible", True)
42 self.browser.connect("preview-mp3", self.re_emit_preview)

Subscribers

People subscribed via source and target branches

to all changes: