libubuntuone

Merge lp:~sil/libubuntuone/better-user-agent into lp:libubuntuone

  1. better-user-agent
  2. Merge into trunk
Proposed by Stuart Langridge
Status: Merged
Approved by: Rodrigo Moya
Approved revision: 48
Merged at revision: not available
Proposed branch: lp:~sil/libubuntuone/better-user-agent
Merge into: lp:libubuntuone
Diff against target: 31 lines (+10/-1)
1 file modified
libubuntuone/u1-music-store.c (+10/-1)
To merge this branch: bzr merge lp:~sil/libubuntuone/better-user-agent
Reviewer Review Type Date Requested Status
Rodrigo Moya (community) Approve
Review via email: mp+20529@code.launchpad.net

Commit message

Add ourselves to the user agent, because the 7d servers browser-detect based on user agent and carefully don't serve required JavaScript to us if they don't recognise our user agent

To post a comment you must log in.
Revision history for this message
Stuart Langridge (sil) wrote :

Add ourselves to the user agent, because the 7d servers browser-detect based on user agent and carefully don't serve required JavaScript to us if they don't recognise our user agent. ASP.NET fail.

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libubuntuone/u1-music-store.c'
2--- libubuntuone/u1-music-store.c 2010-03-02 10:07:48 +0000
3+++ libubuntuone/u1-music-store.c 2010-03-03 11:19:13 +0000
4@@ -574,6 +574,7 @@
5 {
6 GtkWidget *scroll;
7 gchar *real_url;
8+ gchar *new_user_agent;
9
10 music_store->priv = g_new0 (U1MusicStorePrivate, 1);
11
12@@ -588,10 +589,18 @@
13 gtk_widget_show (scroll);
14
15 music_store->priv->web_viewer = webkit_web_view_new ();
16+
17+ new_user_agent = g_strdup_printf("%s U1MusicStore/" VERSION ,
18+ webkit_web_settings_get_user_agent (webkit_web_view_get_settings (WEBKIT_WEB_VIEW (music_store->priv->web_viewer)))
19+ );
20+ g_debug(new_user_agent);
21+
22 g_object_set (G_OBJECT (webkit_web_view_get_settings (WEBKIT_WEB_VIEW (music_store->priv->web_viewer))),
23- "user-agent", "U1MusicStore widget (" VERSION ")",
24+ "user-agent", new_user_agent,
25 NULL);
26
27+ g_free(new_user_agent);
28+
29 g_signal_connect (G_OBJECT (music_store->priv->web_viewer), "navigation-policy-decision-requested",
30 G_CALLBACK (navigation_requested_cb), music_store);
31 g_signal_connect (G_OBJECT (music_store->priv->web_viewer), "load-finished",

Subscribers

People subscribed via source and target branches