Merge into trunk : carbonize : Code : txStatsD

Status:	Merged
Approved by:	Sidnei da Silva on 2012-01-20
Approved revision:	63
Merged at revision:	58
Proposed branch:	lp:~sidnei/txstatsd/carbonize
Merge into:	lp:txstatsd
Diff against target:	0 lines
To merge this branch:	bzr merge lp:~sidnei/txstatsd/carbonize
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Curtis Caravone (community)		Approve on 2011-12-19
Lucio Torre (community)	2011-12-01	Approve on 2011-12-02
Review via email: mp+84175@code.launchpad.net

Commit message

Replace GraphiteClientProtocol with CarbonClientManager

Description of the change

Replaces our naive GraphiteClientProtocol implementation by carbon's own
CarbonClientManager. As a bonus we get to support ConsistentHashing out of the
box. Configuration options for routing and XXX fixes to come later.

Revision history for this message

Lucio Torre (lucio.torre) on 2011-12-02:

#

review: Approve

Revision history for this message

Curtis Caravone (caravone) wrote on 2011-12-19:

#

Deleting code and replacing it with a library component that's maintained by somebody else? I love it!

review: Approve

Revision history for this message

Ubuntu One Server Tarmac Bot (ubuntuone-server-tarmac) wrote on 2012-01-20:

#

Download full text (20.6 KiB)

The attempt to merge lp:~sidnei/txstatsd/carbonize into lp:txstatsd failed. Below is the output from the failed tests.

txstatsd.tests.metrics.     test_all ...   TestDistinctMetricReporter
    test_chi_square ...     test_hash_chars ...   TestPlugin
    test_factory ...   TestZeros
    test_zeros ... txstatsd.tests.metrics.ReporterMetric
tests.metrics.rMetric
percentiles ...     test_std_dev ...   TestTimingSeriesEvents
percentiles ...     test_std_dev ...     test_values ... txstatsd.tests.stats.test_ewma
enMinute
eight_minutes ...     test_five_minutes ...     test_four_minutes ...     test_nine_minutes ...     test_one_minute ... />test_distinct
[OK]
/> [OK]
[SKIPPED]
[OK]
[OK]
[OK]
/>test_histogrammetric
/> />histogram_of_numbers_1_through_10000 ... [OK]
/>histogram_with_zero_recorded_values ... [OK]
/>test_timermetric
/> [OK]
/>fifteen_minute_rate ... [OK]
/>five_minute_rate ... [OK]
[OK]
[OK]
[OK]
[OK]
[OK]
/>one_minute_rate ... [OK]
[OK]
[OK]
/> [OK]
[OK]
[OK]
[OK]
[OK]
[OK]
[OK]
/> /> [OK]
/>eleven_minutes ... [OK]
/>fifteen_minutes ... [OK]
[OK]
[OK]
[OK]
/>fourteen_minutes ... [OK]
[OK]
...

The attempt to merge lp:~sidnei/txstatsd/carbonize into lp:txstatsd failed. Below is the output from the failed tests.

txstatsd.tests.metrics.test_distinct
  TestDistinct
    test_all ...                                                           [OK]
  TestDistinctMetricReporter
    test_reports ...                                                       [OK]
  TestHash
    test_chi_square ...                                               [SKIPPED]
    test_hash_chars ...                                                    [OK]
  TestPlugin
    test_factory ...                                                       [OK]
  TestZeros
    test_zeros ...                                                         [OK]
txstatsd.tests.metrics.test_histogrammetric
  TestHistogramReporterMetric
    test_histogram_of_numbers_1_through_10000 ...                          [OK]
    test_histogram_with_zero_recorded_values ...                           [OK]
txstatsd.tests.metrics.test_timermetric
  TestBlankTimerMetric
    test_count ...                                                         [OK]
    test_fifteen_minute_rate ...                                           [OK]
    test_five_minute_rate ...                                              [OK]
    test_max ...                                                           [OK]
    test_mean ...                                                          [OK]
    test_mean_rate ...                                                     [OK]
    test_min ...                                                           [OK]
    test_no_values ...                                                     [OK]
    test_one_minute_rate ...                                               [OK]
    test_percentiles ...                                                   [OK]
    test_std_dev ...                                                       [OK]
  TestTimingSeriesEvents
    test_count ...                                                         [OK]
    test_max ...                                                           [OK]
    test_mean ...                                                          [OK]
    test_min ...                                                           [OK]
    test_percentiles ...                                                   [OK]
    test_std_dev ...                                                       [OK]
    test_values ...                                                        [OK]
txstatsd.tests.stats.test_ewma
  TestEwmaFifteenMinute
    test_eight_minutes ...                                                 [OK]
    test_eleven_minutes ...                                                [OK]
    test_fifteen_minutes ...                                               [OK]
    test_first_tick ...                                                    [OK]
    test_five_minutes ...                                                  [OK]
    test_four_minutes ...                                                  [OK]
    test_fourteen_minutes ...                                              [OK]
    test_nine_minutes ...                                                  [OK]
    test_one_minute ...                                                    [OK]
    test_seven_minutes ...                                                 [OK]
    test_six_minutes ...                                                   [OK]
    test_ten_minutes ...                                                   [OK]
    test_thirteen_minutes ...                                              [OK]
    test_three_minutes ...                                                 [OK]
    test_twelve_minutes ...                                                [OK]
    test_two_minutes ...                                                   [OK]
  TestEwmaFiveMinute
    test_eight_minutes ...                                                 [OK]
    test_eleven_minutes ...                                                [OK]
    test_fifteen_minutes ...                                               [OK]
    test_first_tick ...                                                    [OK]
    test_five_minutes ...                                                  [OK]
    test_four_minutes ...                                                  [OK]
    test_fourteen_minutes ...                                              [OK]
    test_nine_minutes ...                                                  [OK]
    test_one_minute ...                                                    [OK]
    test_seven_minutes ...                                                 [OK]
    test_six_minutes ...                                                   [OK]
    test_ten_minutes ...                                                   [OK]
    test_thirteen_minutes ...                                              [OK]
    test_three_minutes ...                                                 [OK]
    test_twelve_minutes ...                                                [OK]
    test_two_minutes ...                                                   [OK]
  TestEwmaOneMinute
    test_eight_minutes ...                                                 [OK]
    test_eleven_minutes ...                                                [OK]
    test_fifteen_minutes ...                                               [OK]
    test_first_tick ...                                                    [OK]
    test_five_minutes ...                                                  [OK]
    test_four_minutes ...                                                  [OK]
    test_fourteen_minutes ...                                              [OK]
    test_nine_minutes ...                                                  [OK]
    test_one_minute ...                                                    [OK]
    test_seven_minutes ...                                                 [OK]
    test_six_minutes ...                                                   [OK]
    test_ten_minutes ...                                                   [OK]
    test_thirteen_minutes ...                                              [OK]
    test_three_minutes ...                                                 [OK]
    test_twelve_minutes ...                                                [OK]
    test_two_minutes ...                                                   [OK]
txstatsd.tests.stats.test_exponentiallydecayingsample
  TestExponentiallyDecayingSample
    test_100_out_of_1000_elements ...                                      [OK]
    test_100_out_of_10_elements ...                                        [OK]
    test_heavily_biased_100_out_of_1000_elements ...                       [OK]
txstatsd.tests.stats.test_uniformsample
  TestUniformSample
    test_100_out_of_1000_elements ...                                      [OK]
    test_100_out_of_10_elements ...                                        [OK]
txstatsd.tests.test_client
  TestClient
    test_twistedstatsd_with_malformed_address_and_errback ...              [OK]
    test_twistedstatsd_with_malformed_address_and_no_errback ...           [OK]
    test_twistedstatsd_write_with_wellformed_address ...                   [OK]
    test_udpstatsd_malformed_address ...                                   [OK]
    test_udpstatsd_socket_nonblocking ...                                  [OK]
    test_udpstatsd_wellformed_address ...                                  [OK]
txstatsd.tests.test_configurableprocessor
  FlushMessagesTest
    test_flush_counter_with_empty_prefix ...                               [OK]
    test_flush_counter_with_prefix ...                                     [OK]
    test_flush_plugin ...                                                  [OK]
    test_flush_single_timer_multiple_times ...                             [OK]
    test_flush_single_timer_single_time ...                                [OK]
  FlushMeterMetricMessagesTest
    test_flush_meter_metric_with_prefix ...                                [OK]
txstatsd.tests.test_loggingprocessor
  TestLoggingMessageProcessor
    test_logger ...                                                        [OK]
    test_logger_plugin ...                                                 [OK]
    test_logger_with_no_info ...                                           [OK]
    test_logger_with_non_callable_info ...                                 [OK]
txstatsd.tests.test_metrics
  TestExtendedMetrics
    test_counter ...                                                       [OK]
    test_empty_namespace ...                                               [OK]
    test_gauge ...                                                         [OK]
    test_generic ...                                                       [OK]
    test_meter ...                                                         [OK]
    test_timing ...                                                        [OK]
    test_timing_automatic ...                                              [OK]
    test_timing_automatic_implicit_reset ...                               [OK]
  TestMetrics
    test_counter ...                                                       [OK]
    test_empty_namespace ...                                               [OK]
    test_gauge ...                                                         [OK]
    test_generic ...                                                       [OK]
    test_meter ...                                                         [OK]
    test_timing ...                                                        [OK]
    test_timing_automatic ...                                              [OK]
    test_timing_automatic_implicit_reset ...                               [OK]
txstatsd.tests.test_process
  TestSystemPerformance
    test_ioinfo ...                                                        [OK]
    test_ioinfo_with_get_io_counters ...                                   [OK]
    test_loadinfo ...                                                      [OK]
    test_meminfo ...                                                       [OK]
    test_netdev ...                                                        [OK]
    test_netinfo_no_get_connections ...                                    [OK]
    test_netinfo_with_get_connections ...                                  [OK]
    test_reactor_stats ...                                                 [OK]
    test_read ...                                                          [OK]
    test_self_statinfo ...                                                 [OK]
    test_self_statinfo_with_num_threads ...                                [OK]
    test_statinfo ...                                                      [OK]
    test_threadpool_stats ...                                              [OK]
txstatsd.tests.test_processor
  FlushMessagesTest
    test_flush_counter ...                                                 [OK]
    test_flush_counter_one_second_interval ...                             [OK]
    test_flush_distinct_metric ...                                         [OK]
    test_flush_gauge_metric ...                                            [OK]
    test_flush_no_stats ...                                                [OK]
    test_flush_plugin_arguments ...                                        [OK]
    test_flush_single_timer_50th_percentile ...                            [OK]
    test_flush_single_timer_multiple_times ...                             [OK]
    test_flush_single_timer_single_time ...                                [OK]
  FlushMeterMetricMessagesTest
    test_flush_meter_metric ...                                            [OK]
  ProcessMessagesTest
    test_receive_counter ...                                               [OK]
    test_receive_counter_no_value ...                                      [OK]
    test_receive_counter_rate ...                                          [OK]
    test_receive_distinct_metric ...                                       [OK]
    test_receive_gauge_metric ...                                          [OK]
    test_receive_message_no_fields ...                                     [OK]
    test_receive_not_enough_fields ...                                     [OK]
    test_receive_timer ...                                                 [OK]
    test_receive_timer_no_value ...                                        [OK]
    test_receive_too_many_fields ...                                       [OK]
txstatsd.tests.test_service
  ClientManagerStatsTestCase
    test_report_client_manager_stats ...                                   [OK]
  GlueOptionsTestCase
    test_cmdline_overrides_config ...                                      [OK]
    test_defaults ...                                                      [OK]
    test_ensure_config_values_coerced ...                                  [OK]
    test_no_config_option ...                                              [OK]
    test_reads_from_config ...                                             [OK]
    test_set_parameter ...                                                 [OK]
    test_support_default_not_in_config ...                                 [OK]
    test_support_plugin_sections ...                                       [OK]
  ServiceTestsBuilder_EPollReactor
    test_carbon_client_options ...                                         [OK]
    test_default_clients ...                                               [OK]
    test_monitor_response ...                                              [OK]
    test_multiple_clients ...                                              [OK]
    test_service ...                                                       [OK]
  ServiceTestsBuilder_Glib2Reactor
    test_carbon_client_options ...                                         [OK]
    test_default_clients ...                                               [OK]
    test_monitor_response ...                                              [OK]
    test_multiple_clients ...                                              [OK]
    test_service ...                                                       [OK]
  ServiceTestsBuilder_Gtk2Reactor
    test_carbon_client_options ...                                         [OK]
    test_default_clients ...                                               [OK]
    test_monitor_response ...                                              [OK]
/usr/lib/pymodules/python2.6/gtk-2.0/gtk/__init__.py:57: GtkWarning: could not open display
    test_multiple_clients ...                                              [OK]
    test_service ...                                                       [OK]
  ServiceTestsBuilder_IOCPReactor
    test_carbon_client_options ...                                    [SKIPPED]
    test_default_clients ...                                          [SKIPPED]
    test_monitor_response ...                                         [SKIPPED]
    test_multiple_clients ...                                         [SKIPPED]
    test_service ...                                                  [SKIPPED]
  ServiceTestsBuilder_KQueueReactor
    test_carbon_client_options ...                                    [SKIPPED]
    test_default_clients ...                                          [SKIPPED]
    test_monitor_response ...                                         [SKIPPED]
    test_multiple_clients ...                                         [SKIPPED]
    test_service ...                                                  [SKIPPED]
  ServiceTestsBuilder_PollReactor
    test_carbon_client_options ...                                         [OK]
    test_default_clients ...                                               [OK]
    test_monitor_response ...                                              [OK]
    test_multiple_clients ...                                              [OK]
    test_service ...                                                       [OK]
  ServiceTestsBuilder_SelectReactor
    test_carbon_client_options ...                                         [OK]
    test_default_clients ...                                               [OK]
    test_monitor_response ...                                              [OK]
    test_multiple_clients ...                                              [OK]
    test_service ...                                                       [OK]
  ServiceTestsBuilder_Win32Reactor
    test_carbon_client_options ...                                    [SKIPPED]
    test_default_clients ...                                          [SKIPPED]
    test_monitor_response ...                                         [SKIPPED]
    test_multiple_clients ...                                         [SKIPPED]
    test_service ...                                                  [SKIPPED]
  StatsDOptionsTestCase
    test_support_multiple_carbon_cache_options ...                       [FAIL]

===============================================================================
[SKIPPED]: txstatsd.tests.metrics.test_distinct.TestHash.test_chi_square

Takes too long to run every time.
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_IOCPReactor.test_carbon_client_options

No module named win32api
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_IOCPReactor.test_default_clients

No module named win32api
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_IOCPReactor.test_monitor_response

No module named win32api
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_IOCPReactor.test_multiple_clients

No module named win32api
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_IOCPReactor.test_service

No module named win32api
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_KQueueReactor.test_carbon_client_options

'module' object has no attribute 'kqueuereactor'
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_KQueueReactor.test_default_clients

'module' object has no attribute 'kqueuereactor'
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_KQueueReactor.test_monitor_response

'module' object has no attribute 'kqueuereactor'
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_KQueueReactor.test_multiple_clients

'module' object has no attribute 'kqueuereactor'
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_KQueueReactor.test_service

'module' object has no attribute 'kqueuereactor'
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_Win32Reactor.test_carbon_client_options

No module named win32file
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_Win32Reactor.test_default_clients

No module named win32file
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_Win32Reactor.test_monitor_response

No module named win32file
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_Win32Reactor.test_multiple_clients

No module named win32file
===============================================================================
[SKIPPED]: txstatsd.tests.test_service.ServiceTestsBuilder_Win32Reactor.test_service

No module named win32file
===============================================================================
[FAIL]: txstatsd.tests.test_service.StatsDOptionsTestCase.test_support_multiple_carbon_cache_options

Traceback (most recent call last):
  File "/usr/lib/python2.6/unittest.py", line 279, in run
    testMethod()
  File "/home/tarmac/cache/txstatsd/trunk/txstatsd/tests/test_service.py", line 151, in test_support_multiple_carbon_cache_options
    ["127.0.0.1", "127.0.0.2", "127.0.0.3"])
exceptions.AssertionError: ['127.0.0.3', '127.0.0.1', '127.0.0.2'] != ['127.0.0.1', '127.0.0.2', '127.0.0.3']
-------------------------------------------------------------------------------
Ran 194 tests in 6.707s

FAILED (skips=16, failures=1, successes=177)

Revision history for this message

Ubuntu One Server Tarmac Bot (ubuntuone-server-tarmac) wrote on 2012-01-20:

#

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

txStatsD

Merge lp:~sidnei/txstatsd/carbonize into lp:txstatsd

Commit message

Description of the change

Preview Diff

Subscribers