Merge lp:~sidnei/lazr-js/newer-buildout into lp:lazr-js
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gary Poster on 2010-03-16 | ||||
| Approved revision: | 173 | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp:~sidnei/lazr-js/newer-buildout | ||||
| Merge into: | lp:lazr-js | ||||
| Diff against target: |
1085 lines (+610/-384) 6 files modified
Makefile (+3/-2) bootstrap.py (+126/-103) distribute_setup.py (+477/-0) ez_setup.py (+0/-275) setup.py (+2/-2) versions.cfg (+2/-2) |
||||
| To merge this branch: | bzr merge lp:~sidnei/lazr-js/newer-buildout | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gary Poster (community) | 2010-03-16 | Approve on 2010-03-16 | |
| Graham Binns (community) | 2010-03-16 | Abstain on 2010-03-16 | |
|
Review via email:
|
|||
Description of the Change
- Update zc.buildout to 1.4.3
- Replace setuptools by distribute, since the former doesn't work for
me anymore on Lucid.
- 172. By Sidnei da Silva on 2010-03-16
-
- Revert unwanted change
| Gary Poster (gary) wrote : | # |
Hi Sidnei. Looks good, but there's a practical problem in that it doesn't work for me on Karmic. Interesting that setuptools doesn't work for you on Lucid. More below.
The Makefile fails for me on Karmic like this:
bzr checkout lp:lazr-source-dependencies download-cache
mkdir eggs
if test ! -h src-py/lazrjs ; then \
ln -s ../src-js/lazrjs src-py/lazrjs;\
fi
python -S bootstrap.py \
--distribute_
--download-
Downloading file://
Extracting in /tmp/tmpTmz0tV
Now working in /tmp/tmpTmz0tV/
Building a Distribute egg in /home/gary/
/home/gary/
Traceback (most recent call last):
File "bootstrap.py", line 147, in <module>
PYTHONPATH=
AttributeError: 'NoneType' object has no attribute 'location'
make: *** [bin/buildout] Error 1
This is a general problem with buildout and a system Python. I see we are using a hacked version of my old bootstrap.py. I've fixed this particular problem in my buildout branch for Jim. However, when I copy over my new bootstrap.py, I get a new error.
gary@garybuntu:
if test ! -h src-py/lazrjs ; then \
ln -s ../src-js/lazrjs src-py/lazrjs;\
fi
python -S bootstrap.py \
--distribute \
--download-
Downloading file://
Extracting in /tmp/tmpBtweFh
Now working in /tmp/tmpBtweFh/
Building a Distribute egg in /home/gary/
/home/gary/
/home/gary/
pkg_resources
/home/gary/
pkg_resources
Traceback (most recent call last):
File "bootstrap.py", line 179, in <module>
ws.
File "/usr/lib/
needed = self.resolve(
File "/usr/lib/
raise DistributionNot
pkg_resources.
make: *** [bin/buildout] Error 1
That's...
- 173. By Sidnei da Silva on 2010-03-16
-
- Merge from gary's branch
| Gary Poster (gary) wrote : | # |
You reported my changes continued to work for you on lucid.
Heh, ok, I don't like my sys.modules thing but I don't know anything better, so sure, approved. :-)

I'm not happy reviewing this branch as I don't have the necessary knowledge. I'm asking Gary to either review this or find someone else who has the necessary contextual knowledge to do so.