Yeah, definitely needs tests, otherwise very nice. I guess the notify problems with overlayfs aren't a big deal if we're never updating the template underneath a container?
https://codereview.appspot.com/12801044/diff/1/container/lxc/lxc.go File container/lxc/lxc.go (right):
https://codereview.appspot.com/12801044/diff/1/container/lxc/lxc.go#newcode134 container/lxc/lxc.go:134: if !template.IsConstructed() { Would it be reasonable to extract this block as a method?
https://codereview.appspot.com/12801044/
« Back to merge proposal
Yeah, definitely needs tests, otherwise very nice. I guess the notify
problems with overlayfs aren't a big deal if we're never updating the
template underneath a container?
https:/ /codereview. appspot. com/12801044/ diff/1/ container/ lxc/lxc. go lxc/lxc. go (right):
File container/
https:/ /codereview. appspot. com/12801044/ diff/1/ container/ lxc/lxc. go#newcode134 lxc/lxc. go:134: if !template. IsConstructed( ) {
container/
Would it be reasonable to extract this block as a method?
https:/ /codereview. appspot. com/12801044/