Merge lp:~sidnei/juju-core/lxc-clone-with-overlayfs into lp:~go-bot/juju-core/trunk
Proposed by
Sidnei da Silva
Status: | Work in progress |
---|---|
Proposed branch: | lp:~sidnei/juju-core/lxc-clone-with-overlayfs |
Merge into: | lp:~go-bot/juju-core/trunk |
Diff against target: |
172 lines (+60/-33) 2 files modified
container/lxc/lxc.go (+58/-31) container/lxc/mock/mock-lxc.go (+2/-2) |
To merge this branch: | bzr merge lp:~sidnei/juju-core/lxc-clone-with-overlayfs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+180445@code.launchpad.net |
Description of the change
Faster container creation via lxc-clone
Use the newer Clone arguments in golxc to request a snapshot container with a
specific backing store, create base template for selected distro if one
doesn't exist yet.
To post a comment you must log in.
Unmerged revisions
- 1676. By Sidnei da Silva
-
- Revert upstart change
- 1675. By Sidnei da Silva
-
- Default to auto
- 1674. By Sidnei da Silva
-
- Merge from trunk
- 1673. By Sidnei da Silva
-
- Expose more settings via create and clone
- 1672. By Sidnei da Silva
-
- Fallback to no snapshot.
- 1671. By Sidnei da Silva
-
- Switch to inictl instead
- 1670. By Sidnei da Silva
-
- kill -HUP upstart so it picks up the new service.
- 1669. By Sidnei da Silva
-
- Some IRL fixes
- 1668. By Sidnei da Silva
-
- Minimal hack to get started
Looks like a nice change.
I'd like to see some tests to ensure the new template stuff is processed
correctly. eg is the container template created as expected, is it only
done once, is the filename done correctly if manager name is "" etc etc.
Also, maybe a comment as to why the newly added HUP is needed in the
upstart script.
https:/ /codereview. appspot. com/12801044/ diff/1/ container/ lxc/lxc. go lxc/lxc. go (right):
File container/
https:/ /codereview. appspot. com/12801044/ diff/1/ container/ lxc/lxc. go#newcode133 lxc/lxc. go:133: template := lxcObjectFactor y.New(templateN ame)
container/
What if manager.name is ""? There's a few lines of code above this
accounts for the fact that manager name might be empty so I think
something similar is needed for making the template name also? Otherwise
we will end up with a template name like "-precise-template" if
manager.name is ""
https:/ /codereview. appspot. com/12801044/