Merge lp:~sidnei/charmsupport/fix-relations-for-id into lp:charmsupport

Proposed by Sidnei da Silva
Status: Merged
Approved by: Matthew Wedgwood
Approved revision: 51
Merged at revision: 41
Proposed branch: lp:~sidnei/charmsupport/fix-relations-for-id
Merge into: lp:charmsupport
Diff against target: 37 lines (+4/-4)
2 files modified
charmsupport/hookenv.py (+1/-1)
tests/test_hookenv.py (+3/-3)
To merge this branch: bzr merge lp:~sidnei/charmsupport/fix-relations-for-id
Reviewer Review Type Date Requested Status
Matthew Wedgwood (community) Approve
Review via email: mp+163376@code.launchpad.net

Commit message

Fix relations_for_id to use relation_id not relation_ids.

Description of the change

Fix relations_for_id to use relation_id not relation_ids.

To post a comment you must log in.
Revision history for this message
Matthew Wedgwood (mew) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmsupport/hookenv.py'
2--- charmsupport/hookenv.py 2013-05-06 17:30:18 +0000
3+++ charmsupport/hookenv.py 2013-05-10 22:19:25 +0000
4@@ -167,7 +167,7 @@
5 def relations_for_id(relid=None):
6 "Get relations of a specific relation ID"
7 relation_data = []
8- relid = relid or relation_ids()
9+ relid = relid or relation_id()
10 for unit in related_units(relid):
11 unit_data = relation_for_unit(unit, relid)
12 unit_data['__relid__'] = relid
13
14=== modified file 'tests/test_hookenv.py'
15--- tests/test_hookenv.py 2013-04-24 17:45:30 +0000
16+++ tests/test_hookenv.py 2013-05-10 22:19:25 +0000
17@@ -269,18 +269,18 @@
18 relation_get.assert_called_with(unit=unit, rid=None)
19 self.assertFalse(remote_unit.called)
20
21- @patch('charmsupport.hookenv.relation_ids')
22+ @patch('charmsupport.hookenv.relation_id')
23 @patch('charmsupport.hookenv.related_units')
24 @patch('charmsupport.hookenv.relation_for_unit')
25 def test_gets_relations_for_id(self, relation_for_unit, related_units,
26- relation_ids):
27+ relation_id):
28 relid = 123
29 units = ['foo', 'bar']
30 unit_data = [
31 {'foo-item': 'bar-item'},
32 {'foo-item2': 'bar-item2'},
33 ]
34- relation_ids.return_value = relid
35+ relation_id.return_value = relid
36 related_units.return_value = units
37 relation_for_unit.side_effect = unit_data
38

Subscribers

People subscribed via source and target branches