Merge lp:~shuff/ubuntu/precise/net-snmp/fix-for-701944 into lp:ubuntu/precise/net-snmp

[Steve Huff]

This branch fixes bug #701944.

The fundamental issue is that the postinst and postrm scripts for the snmpd package attempt to add and remove the 'snmp' user and group, and these scripts fail when that user and/or group are not defined locally on the system, but rather are provided by a directory service. My fix adds additional checks for local definition of user and group by grepping /etc/passwd and /etc/group.

I am submitting this patch against the current trunk of net-snmp; however, given that this issue affects previous distributions, I am particularly interested in seeing this fix backported to lucid (as it is a bugfix, not an enhancement). I'm not entirely sure how to make this happen, and I'd appreciate any help you can provide.

[lp:~shuff/ubuntu/precise/net-snmp/fix-for-701944]

59. By Steve Huff on 2012-07-17

typo fix - /etc/group instead of /etc/passwd

Unmerged revisions

59. By Steve Huff on 2012-07-17

typo fix - /etc/group instead of /etc/passwd

58. By Steve Huff on 2012-02-06

updated changelog

57. By Steve Huff on 2012-02-06

add dependency on grep to support script modifications

56. By Steve Huff on 2012-02-06

make sure snmp user/group are local before trying to modify (#710944)

the postinst and postrm scripts fail in an environment where the 'snmp' user
and group are provided via a directory service (e.g. LDAP). this patch adds a
check to make sure the user and group are local before attempting to remove or
create them.

=== modified file 'debian/changelog'
--- debian/changelog	2012-01-23 09:44:25 +0000
+++ debian/changelog	2012-07-17 20:50:24 +0000
@@ -1,3 +1,12 @@
+net-snmp (5.4.3~dfsg-2.4ubuntu2) precise; urgency=low
+
+  * Modify snmpd.postinst and snmpd.postrm scripts
+    - don't try to add/remove 'snmp' user and group if they are not defined
+      locally (e.g. provided by a directory service) (LP: #701944)
+    - add dependency on grep to support above modification
+
+ -- Steve Huff <[e-mail]>  Mon, 6 Feb 2012 11:40:00 -0500
+
 net-snmp (5.4.3~dfsg-2.4ubuntu1) precise; urgency=low
 
   * Merge from Debian testing.  Remaining changes:

=== modified file 'debian/control'
--- debian/control	2011-12-14 15:48:05 +0000
+++ debian/control	2012-07-17 20:50:24 +0000
@@ -15,7 +15,7 @@
 Section: net
 Priority: optional
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, debconf, lsb-base (>= 3.2-13)
+Depends: ${shlibs:Depends}, ${misc:Depends}, adduser, debconf, grep, lsb-base (>= 3.2-13)
 Description: SNMP (Simple Network Management Protocol) agents
  The Simple Network Management Protocol (SNMP) provides a framework
  for the exchange of management information between agents (servers)

=== modified file 'debian/snmpd.postinst'
--- debian/snmpd.postinst	2010-06-22 14:04:48 +0000
+++ debian/snmpd.postinst	2012-07-17 20:50:24 +0000
@@ -7,10 +7,16 @@
 
 if [ "x$1" = xconfigure ]; then
 	if [ ! `getent group snmp >/dev/null` ]; then
-		 deluser --quiet --system snmp
+        if [ `grep -q -c snmp /etc/group` ]; then
+            deluser --quiet --system snmp
+        fi
 	fi
-	adduser --quiet --system --group --no-create-home --home /var/lib/snmp snmp
-	chown -R snmp:snmp /var/lib/snmp
+	if [ ! `getent passwd snmp >/dev/null` ]; then
+        if [ `grep -q -c snmp /etc/passwd` ]; then
+            adduser --quiet --system --group --no-create-home --home /var/lib/snmp snmp
+        fi
+        chown -R snmp:snmp /var/lib/snmp
+    fi
 fi
 
 # Remove shutdown and reboot links; this init script does not need them.

=== modified file 'debian/snmpd.postrm'
--- debian/snmpd.postrm	2009-11-26 01:27:00 +0000
+++ debian/snmpd.postrm	2012-07-17 20:50:24 +0000
@@ -11,18 +11,22 @@
     rm -f /var/run/snmpd.pid
     rm -f /var/run/snmptrapd.pid
     if getent passwd snmp >/dev/null; then
-	if [ -x /usr/sbin/deluser ]; then
-	    deluser --quiet --system snmp
-	else
-	    echo "Can't remove user snmp. Please remove this user by hand."
-	fi
+        if [ `grep -q -c snmp /etc/passwd` ]; then
+            if [ -x /usr/sbin/deluser ]; then
+                deluser --quiet --system snmp
+            else
+                echo "Can't remove user snmp. Please remove this user by hand."
+            fi
+        fi
     fi
     if getent group snmp >/dev/null; then
-	if [ -x /usr/sbin/delgroup ]; then
-	    delgroup --quiet --system snmp
-	else
-	    echo "Can't remove group snmp. Please remove this group by hand."
-	fi
+        if [ `grep -q -c snmp /etc/group` ]; then
+            if [ -x /usr/sbin/delgroup ]; then
+                delgroup --quiet --system snmp
+            else
+                echo "Can't remove group snmp. Please remove this group by hand."
+            fi
+        fi
     fi
 fi