Merge lp:~shockone89/audience/universal-shortcuts into lp:~audience-members/audience/trunk

Proposed by Volodymyr Shatsky on 2013-04-07
Status: Rejected
Rejected by: Zisu Andrei on 2016-10-26
Proposed branch: lp:~shockone89/audience/universal-shortcuts
Merge into: lp:~audience-members/audience/trunk
Diff against target: 16 lines (+5/-1)
1 file modified
Audience/Audience.vala (+5/-1)
To merge this branch: bzr merge lp:~shockone89/audience/universal-shortcuts
Reviewer Review Type Date Requested Status
Zisu Andrei (community) Disapprove on 2016-10-26
Artem Anufrij functionality Needs Fixing on 2014-11-26
Volodymyr Shatsky Pending
Review via email: mp+157533@code.launchpad.net

Description of the change

Finally shortcuts work with Russian layout.

To post a comment you must log in.
Volodymyr Shatsky (shockone89) wrote :

Cody, I saw your question about this keyboard layouts thing on some mailing list the other day. Maybe this technique will be useful for your Pantheon Terminal.

Artem Anufrij (artem-anufrij) wrote :

I can't confirm this solution.

On my system (russian layout) CTRL+Q (as example) doesn't work.

review: Needs Fixing (functionality)
Zisu Andrei (matzipan) wrote :

Rejecting since bug #1235489 has been marked as fixed.

review: Disapprove

Unmerged revisions

251. By Volodymyr Shatsky on 2013-04-07

Shortcuts work with all keyboard layouts

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Audience/Audience.vala'
2--- Audience/Audience.vala 2013-04-02 16:46:22 +0000
3+++ Audience/Audience.vala 2013-04-07 04:41:18 +0000
4@@ -218,7 +218,11 @@
5
6 //shortcuts
7 this.mainwindow.key_press_event.connect ( (e) => {
8- switch (e.keyval) {
9+ //Covert the key to the English layout
10+ Gdk.KeymapKey keymap_key = Gdk.KeymapKey () {keycode = e.hardware_keycode};
11+ uint keyval = Gdk.Keymap.get_default ().lookup_key (keymap_key);
12+
13+ switch (keyval) {
14 case Gdk.Key.p:
15 case Gdk.Key.space:
16 video_player.playing = !video_player.playing;

Subscribers

People subscribed via source and target branches