Merge lp:~shlomister/ubiquity/fix-bug-560114 into lp:ubiquity

[Shlomil]

Fix truncated text in Hebrew and RTL languages

This changes makes Hebrew and RTL text readable and not truncated as it is right now.
Unlike the previous branch I submitted, in this branch the lines are all aligned correctly and it looks real good.

Seems like the line I disabled only for RTL causes a lot of trouble for RTL text labels. I don't know whether this is the proper solution because I don't understand what is the purpose of wrap_fix(). Seems to me like everything works OK without it and in Hebrew it works even better without it.

Please do your best to merge this change or fix it in another way before the release. It is extremely important.

Related to bug 560114.

[Stéphane Graber (stgraber)]

Marking as rejected as apparently this patch isn't relevant with the switch to pygi in ubiquity, based on comments and bug status of bug 560114.

Unmerged revisions

4096. By Shlomil on 2010-04-18

don't mess up allocated width in RTL mode

=== modified file 'ubiquity/frontend/gtk_ui.py'
--- ubiquity/frontend/gtk_ui.py	2010-04-16 10:29:55 +0000
+++ ubiquity/frontend/gtk_ui.py	2010-04-19 04:39:16 +0000
@@ -82,7 +82,8 @@
     old_width, old_height = layout.get_size()
     if old_width / pango.SCALE == allocation.width:
         return
-    layout.set_width(allocation.width * pango.SCALE)
+    if gtk.widget_get_default_direction() != gtk.TEXT_DIR_RTL:
+        layout.set_width(allocation.width * pango.SCALE)
     unused, height = layout.get_size()
     if allocation.height != height / pango.SCALE:
         w.set_size_request(-1, height / pango.SCALE)