Merge lp:~shikhachowdhary28/gtg/Bug1258451 into lp:~gtg/gtg/old-trunk

Proposed by Shikha Chowdhary on 2014-02-14
Status: Rejected
Rejected by: Izidor Matušov on 2014-03-30
Proposed branch: lp:~shikhachowdhary28/gtg/Bug1258451
Merge into: lp:~gtg/gtg/old-trunk
Diff against target: 12 lines (+2/-0)
1 file modified
GTG/core/task.py (+2/-0)
To merge this branch: bzr merge lp:~shikhachowdhary28/gtg/Bug1258451
Reviewer Review Type Date Requested Status
Gtg developers 2014-02-14 Pending
Review via email: mp+206347@code.launchpad.net

Description of the change

Bug #1258451 : The calculated "urgent" due date for a task, i.e. the quantity used for sorting the "Due" column, was wrong for a task with closed sub-tasks.

To post a comment you must log in.
Izidor Matušov (izidor) wrote :

GTG moved the primary code hosting over to Github: https://github.com/getting-things-gnome

If your patch is still relevant and you would like to get it merged, create a pull request on github against branch https://github.com/getting-things-gnome/gtg

Unmerged revisions

1346. By Shikha Chowdhary on 2014-02-11

Fix for Bug1258451

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'GTG/core/task.py'
2--- GTG/core/task.py 2013-12-18 16:20:01 +0000
3+++ GTG/core/task.py 2014-02-14 07:17:12 +0000
4@@ -362,6 +362,8 @@
5 """
6 urg_date = self.due_date
7 for sub in self.get_subtasks():
8+ if sub.get_closed_date() != Date.no_date():
9+ continue
10 sub_urg_date = sub.get_urgent_date()
11 if urg_date >= sub_urg_date:
12 urg_date = sub_urg_date

Subscribers

People subscribed via source and target branches

to status/vote changes: