Code review comment for lp:~shevonar/widelands-website/django1.4

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Hi all. :)

I have been checking in on this merge proposal every now and then to see if there has been some progress. From what I can see the code/dependencies are updated, the only remaining changes are the database migrations, is this correct?

>Do you think it is worth merging or should we directly try moving to 1.5

I think we need to take this gradually. I remember branching this and bumping the dependency to django 1.5 just to check and it seemed more parts of the api had moved around causing failing imports. I didn't look further into it, because I figured we needed to land this first anyways.

While we should do something to sync up with more current releases, simply getting to 1.4 would be huge improvement already. Django 1.4 is an LTS-relese [1] and will therefore get security patches at least until March 2015. I don't think we should stop there, but we would at least be running a release which is currently supported. :)

[1] https://docs.djangoproject.com/en/dev/internals/release-process/#long-term-support-lts-releases

« Back to merge proposal