Merge ~shawn111/pmr:one-shot into pmr:master
Proposed by
Shawn Wang
Status: | Merged |
---|---|
Approved by: | Shawn Wang |
Approved revision: | d133b512a7d07a48e0c41a170816d031e8aa3711 |
Merged at revision: | 21982ef72a320b776ebb57d14c6b2d658681c865 |
Proposed branch: | ~shawn111/pmr:one-shot |
Merge into: | pmr:master |
Diff against target: |
66 lines (+27/-8) 1 file modified
process-merge-requests (+27/-8) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+310165@code.launchpad.net |
To post a comment you must log in.
The requirement I've seen for --one-shot comes from Jenkaas, and my understanding is that in that context the requirement would be more precisely described as an option that causes pmr to land at most one merge request. This doesn't meet that requirement.
Could you push the check down into the loop in merge_mergable_ on_project instead? I'd suggest that the option description should then become something like "Only check for approved merge requests once, and land at most one of them."