Code review comment for lp:~shawn111/bzr/lp_propose_message

Revision history for this message
Richard Wilbur (richard-wilbur) wrote :

Now that I have looked at the diff and the surrounding code in bzrlib/plugins/launchpad/lp_propose.py, I have a comment and a question:

Comment -- Thanks for finally making use of the commit message passed as a parameter into the Proposer class constructor.

Question -- Why lock the source and target branches and look up all the info to create a default message if we are going to ignore it and use the message passed to the Proposer constructor? I'd recommend flipping this routine to first try using self.commit_message, then only if it is None create the other message.

review: Needs Fixing

« Back to merge proposal