Merge lp:~sharoonthomas/openobject-server/patchfor_postgressql_environnonutf8 into lp:openobject-server/5.0

[Sharoon Thomas http://openlabs.co.in]

[Sharoon Thomas http://openlabs.co.in (sharoonthomas)]

If the postgres cluster is on a different encoding or no environment is
specified then the database created will be of encoding SQL_ASCII
(Refer:http://www.postgresql.org/docs/8.4/static/multibyte.html)

Hence template1 will use the specified encoding which is not UTF8.

Line 80 of webservices.py has a simple create command which will err out
in such a situation.

It has to change from:

cr.execute('CREATE DATABASE "%s" ENCODING \'unicode\'' % db_name)
to
cr.execute('CREATE DATABASE "%s" ENCODING \'unicode\' TEMPLATE template0' % db_name)

if not the error would be:

new encoding (UTF8) is incompatible with the encoding of the template database (SQL_ASCII)
HINT: Use the same encoding as in the template database, or use template0 as template.

*** Apologies for the last merge proposal. It had my local settings too.

[lp:~sharoonthomas/openobject-server/patchfor_postgressql_environnonutf8]

1930. By Sharoon Thomas http://openlabs.co.in on 2010-01-12

[IMP]Wrong location of quote

[Christophe CHAUVET (christophe-chauvet)]

Hi

Good point,

Regards,

review: Approve

[Christophe Simonis (OpenERP) (kangol)]

I approve the patch
But that change has already been made by this commit:
http://bazaar.launchpad.net/~<email address hidden>

review: Approve

=== modified file 'bin/service/web_services.py'
--- bin/service/web_services.py	2010-01-06 06:33:08 +0000
+++ bin/service/web_services.py	2010-01-12 12:41:13 +0000
@@ -77,7 +77,7 @@
             cr = db.cursor()
             try:
                 cr.autocommit(True) # avoid transaction block
-                cr.execute('CREATE DATABASE "%s" ENCODING \'unicode\'' % db_name)
+                cr.execute('CREATE DATABASE "%s" ENCODING \'unicode\' TEMPLATE template0' % db_name)
             finally:
                 cr.close()
         finally: