Merge lp:~sforshee/powerd/remove-g-type-init into lp:powerd

Proposed by Seth Forshee
Status: Merged
Approved by: Matt Fischer
Approved revision: 27
Merged at revision: 28
Proposed branch: lp:~sforshee/powerd/remove-g-type-init
Merge into: lp:powerd
Diff against target: 39 lines (+2/-4)
3 files modified
cli/powerd-cli.c (+0/-2)
debian/changelog (+2/-1)
src/powerd.cpp (+0/-1)
To merge this branch: bzr merge lp:~sforshee/powerd/remove-g-type-init
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Matt Fischer (community) Approve
Review via email: mp+166398@code.launchpad.net

Commit message

Remove unnecessary calls to g_type_init()

Description of the change

Remove unnecessary calls to g_type_init()

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:25
http://jenkins.qa.ubuntu.com/job/powerd-ci/39/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-raring-armhf-ci/39

Click here to trigger a rebuild:
http://s-jenkins:8080/job/powerd-ci/39/rebuild

review: Approve (continuous-integration)
Revision history for this message
Matt Fischer (mfisch) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:26
http://jenkins.qa.ubuntu.com/job/powerd-ci/44/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-raring-armhf-ci/44

Click here to trigger a rebuild:
http://s-jenkins:8080/job/powerd-ci/44/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/powerd-autolanding/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/powerd-raring-armhf-autolanding/19/console

review: Needs Fixing (continuous-integration)
27. By Seth Forshee

Merge with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cli/powerd-cli.c'
2--- cli/powerd-cli.c 2013-05-22 20:22:08 +0000
3+++ cli/powerd-cli.c 2013-05-31 16:06:24 +0000
4@@ -324,8 +324,6 @@
5 return -1;
6 }
7
8- g_type_init();
9-
10 powerd_proxy = g_dbus_proxy_new_for_bus_sync(G_BUS_TYPE_SYSTEM,
11 G_DBUS_PROXY_FLAGS_NONE,
12 NULL,
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2013-05-31 15:18:41 +0000
16+++ debian/changelog 2013-05-31 16:06:24 +0000
17@@ -2,8 +2,9 @@
18
19 * Fix use of uninitialized variable in wait_for_fb_thread(). Also
20 change type of the variable to elimante warning on 64-bit builds.
21+ * Remove unnecessary calls to g_type_init()
22
23- -- Seth Forshee <seth.forshee@canonical.com> Fri, 31 May 2013 10:15:13 -0500
24+ -- Seth Forshee <seth.forshee@canonical.com> Fri, 31 May 2013 10:24:56 -0500
25
26 powerd (0.11) raring; urgency=low
27
28
29=== modified file 'src/powerd.cpp'
30--- src/powerd.cpp 2013-05-30 18:50:58 +0000
31+++ src/powerd.cpp 2013-05-31 16:06:24 +0000
32@@ -218,7 +218,6 @@
33 {
34 int i, ret;
35
36- g_type_init();
37 name_id = g_bus_own_name(G_BUS_TYPE_SYSTEM, "com.canonical.powerd",
38 G_BUS_NAME_OWNER_FLAGS_REPLACE, powerd_bus_acquired_cb,
39 powerd_name_acquired_cb, powerd_name_lost_cb, NULL, NULL);

Subscribers

People subscribed via source and target branches