Merge lp:~sforshee/powerd/improve-state-machine-error-handling into lp:powerd

Proposed by Seth Forshee
Status: Merged
Approved by: Matt Fischer
Approved revision: 79
Merged at revision: 79
Proposed branch: lp:~sforshee/powerd/improve-state-machine-error-handling
Merge into: lp:powerd
Diff against target: 21 lines (+3/-1)
1 file modified
src/power-request.c (+3/-1)
To merge this branch: bzr merge lp:~sforshee/powerd/improve-state-machine-error-handling
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+178516@code.launchpad.net

Commit message

Improve error handling in system power state change state machine

Description of the change

Improve error handling in system power state change state machine

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/power-request.c'
2--- src/power-request.c 2013-07-29 16:05:34 +0000
3+++ src/power-request.c 2013-08-05 09:00:40 +0000
4@@ -468,7 +468,7 @@
5
6 static void state_transition_process(void)
7 {
8- guint delay;
9+ guint delay = 0;
10
11 state_machine_source_id = 0;
12 do {
13@@ -483,6 +483,8 @@
14 cur_state_transition_state = process_state_complete(&delay);
15 break;
16 default:
17+ powerd_error("Invalid transition state, setting to idle");
18+ cur_state_transition_state = STATE_TRANSITION_IDLE;
19 break;
20 }
21 } while (delay == 0 &&

Subscribers

People subscribed via source and target branches