Apport

Merge lp:~sforshee/apport/make-iwl-firmware-dumps-private into lp:~apport-hackers/apport/trunk

  1. make-iwl-firmware-dumps-private
  2. Merge into trunk
Proposed by Seth Forshee
Status: Merged
Approved by: Martin Pitt
Approved revision: 2793
Merged at revision: 2793
Proposed branch: lp:~sforshee/apport/make-iwl-firmware-dumps-private
Merge into: lp:~apport-hackers/apport/trunk
Diff against target: 12 lines (+3/-0)
1 file modified
data/iwlwifi_error_dump (+3/-0)
To merge this branch: bzr merge lp:~sforshee/apport/make-iwl-firmware-dumps-private
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
Review via email: mp+217477@code.launchpad.net

Description of the change

Make reports containing iwlwifi firmware dumps private, and subscribe canonical-kernel-team.

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Looks fine, thanks! (As discussed by PM)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/iwlwifi_error_dump'
2--- data/iwlwifi_error_dump 2014-03-27 08:20:17 +0000
3+++ data/iwlwifi_error_dump 2014-04-28 16:53:41 +0000
4@@ -46,6 +46,9 @@
5 try:
6 with open(sysfs_path, 'rb') as f:
7 pr['IwlFwDump'] = f.read()
8+ # Firmware dump could contain sensitive information
9+ pr['LaunchpadPrivate'] = 'yes'
10+ pr['LaunchpadSubscribe'] = 'canonical-kernel-team'
11 except IOError:
12 pass
13

Subscribers

People subscribed via source and target branches