Merge ~seyeongkim/maas:bug-2073731-3.3 into maas:3.3

[Seyeong Kim]

fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Some BMCs (like HPE ILO 5 3.05) seems to not report all the ciphers
that actually are enabled.

Instead of failing commissioning, we now only print out a warning.

Resolves LP:2073731

(cherry picked from commit b2d55fd8c55b36139547e6b1306a7b96286d7875)
(cherry picked from commit 60fbad31927d726ae9d3098e0aedb7aa9a874f11)
(cherry picked from commit 1ae9d903a2c572139c26a79d50d2bb3166e0ce3c)

[MAAS Lander (maas-lander)]

UNIT TESTS
-b bug-2073731-3.3 lp:~seyeongkim/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 538727edcef91b2edcf432a1c22388f5044a5260

review: Approve

[Dariusz Gadomski (dgadomski)]

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b bug-2073731-3.3 lp:~seyeongkim/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/834/console

[MAAS Lander (maas-lander)]

LANDING
-b bug-2073731-3.3 lp:~seyeongkim/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-tester/875/console

[Dariusz Gadomski (dgadomski)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b bug-2073731-3.3 lp:~seyeongkim/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/888/console
COMMIT: 538727edcef91b2edcf432a1c22388f5044a5260

review: Needs Fixing

[Dariusz Gadomski (dgadomski)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b bug-2073731-3.3 lp:~seyeongkim/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 538727edcef91b2edcf432a1c22388f5044a5260

review: Approve

diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
index c7b9b14..b407d0d 100755
--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
@@ -552,8 +552,10 @@ class IPMI(IPMIBase):
         # this one.
 
         if not self._check_ciphers_enabled():
-            print("ERROR: No cipher enabled!", file=sys.stderr)
-            sys.exit(1)
+            # We can't detect any suitable cipher. We still continue,
+            # since we don't trust that the BMC reports all the
+            # ciphers that actually are usable.
+            print("WARNING: No cipher enabled!", file=sys.stderr)
 
         self._config_ipmi_lan_channel_settings()
         self._config_lan_conf_auth()