Merge ~seyeongkim/maas:lp1929478_to_3.1 into maas:3.1

Proposed by Seyeong Kim
Status: Merged
Approved by: Alexsander de Souza
Approved revision: f1ff1bc22d205e356981b2ba3d11ba5677788dc0
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~seyeongkim/maas:lp1929478_to_3.1
Merge into: maas:3.1
Diff against target: 13 lines (+1/-1)
1 file modified
src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py (+1/-1)
Reviewer Review Type Date Requested Status
Jack Lloyd-Walters Approve
MAAS Lander Approve
Review via email: mp+435918@code.launchpad.net

Commit message

Fix utf-8 character error when bmc-config

Related LP and article

https://bugs.launchpad.net/bugs/1892983
https://bugs.launchpad.net/bugs/1929478
https://discourse.maas.io/t/maas-failed-commissioning/4904
(cherry picked from commit 3eec5b5161515a23f58c72638a5ff8aac7486622)

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1929478_to_3.1 lp:~seyeongkim/maas/+git/maas into -b 3.1 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: f1ff1bc22d205e356981b2ba3d11ba5677788dc0

review: Approve
Revision history for this message
Jack Lloyd-Walters (lloydwaltersj) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
2index 42e4c79..4da0512 100755
3--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
4+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
5@@ -190,7 +190,7 @@ class IPMI(BMCConfig):
6 )
7 raise
8 section = None
9- for line in proc.stdout.decode().splitlines():
10+ for line in proc.stdout.decode(errors="surrogateescape").splitlines():
11 line = line.split("#")[0].strip()
12 if not line:
13 continue

Subscribers

People subscribed via source and target branches