Merge ~seyeongkim/maas:lp1929478_to_3.0 into maas:3.0

Proposed by Seyeong Kim
Status: Merged
Approved by: Jack Lloyd-Walters
Approved revision: aee11ba46c59b11bb6f66d2241316e7e882fa773
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~seyeongkim/maas:lp1929478_to_3.0
Merge into: maas:3.0
Diff against target: 13 lines (+1/-1)
1 file modified
src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py (+1/-1)
Reviewer Review Type Date Requested Status
Jack Lloyd-Walters Approve
MAAS Lander Approve
Review via email: mp+435917@code.launchpad.net

Commit message

backport fix for lp1929478 to 3.0

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1929478_to_3.0 lp:~seyeongkim/maas/+git/maas into -b 3.0 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: aee11ba46c59b11bb6f66d2241316e7e882fa773

review: Approve
Revision history for this message
Jack Lloyd-Walters (lloydwaltersj) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
2index 42e4c79..4da0512 100755
3--- a/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
4+++ b/src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py
5@@ -190,7 +190,7 @@ class IPMI(BMCConfig):
6 )
7 raise
8 section = None
9- for line in proc.stdout.decode().splitlines():
10+ for line in proc.stdout.decode(errors="surrogateescape").splitlines():
11 line = line.split("#")[0].strip()
12 if not line:
13 continue

Subscribers

People subscribed via source and target branches