Merge lp:~seyeongkim/charms/trusty/neutron-api/lp1545886 into lp:~openstack-charmers-archive/charms/trusty/neutron-api/next

Proposed by Seyeong Kim
Status: Rejected
Rejected by: James Page
Proposed branch: lp:~seyeongkim/charms/trusty/neutron-api/lp1545886
Merge into: lp:~openstack-charmers-archive/charms/trusty/neutron-api/next
Diff against target: 84 lines (+14/-2)
5 files modified
config.yaml (+5/-0)
hooks/neutron_api_context.py (+4/-0)
templates/icehouse/ml2_conf.ini (+1/-1)
templates/kilo/ml2_conf.ini (+1/-1)
unit_tests/test_neutron_api_context.py (+3/-0)
To merge this branch: bzr merge lp:~seyeongkim/charms/trusty/neutron-api/lp1545886
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Review via email: mp+286269@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #728 neutron-api-next for xtrusia mp286269
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/728/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #633 neutron-api-next for xtrusia mp286269
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/633/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #282 neutron-api-next for xtrusia mp286269
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15099691/
Build: http://10.245.162.36:8080/job/charm_amulet_test/282/

Unmerged revisions

176. By Seyeong Kim

add vni_ranges option

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2016-01-22 15:14:59 +0000
3+++ config.yaml 2016-02-17 09:53:01 +0000
4@@ -126,6 +126,11 @@
5 <physical_network> specifying physical_network names usable for VLAN
6 provider and tenant networks, as well as ranges of VLAN tags on each
7 available for allocation to tenant networks.
8+ vni-ranges:
9+ type: string
10+ default: "1001:2000"
11+ description: |
12+ Space-delimited list of <vxlan_min>:<vxlan_max> for VXLAN provider.
13 # Quota configuration settings
14 quota-security-group:
15 default: 10
16
17=== modified file 'hooks/neutron_api_context.py'
18--- hooks/neutron_api_context.py 2016-01-22 15:14:59 +0000
19+++ hooks/neutron_api_context.py 2016-02-17 09:53:01 +0000
20@@ -228,6 +228,10 @@
21 if vlan_ranges:
22 ctxt['vlan_ranges'] = ','.join(vlan_ranges.split())
23
24+ vni_ranges = config('vni-ranges')
25+ if vni_ranges:
26+ ctxt['vni_ranges'] = ','.join(vni_ranges.split())
27+
28 ctxt['enable_ml2_port_security'] = config('enable-ml2-port-security')
29
30 return ctxt
31
32=== modified file 'templates/icehouse/ml2_conf.ini'
33--- templates/icehouse/ml2_conf.ini 2015-11-09 14:06:56 +0000
34+++ templates/icehouse/ml2_conf.ini 2016-02-17 09:53:01 +0000
35@@ -16,7 +16,7 @@
36 tunnel_id_ranges = 1:1000
37
38 [ml2_type_vxlan]
39-vni_ranges = 1001:2000
40+vni_ranges = {{ vni_ranges }}
41
42 [ml2_type_vlan]
43 network_vlan_ranges = {{ vlan_ranges }}
44
45=== modified file 'templates/kilo/ml2_conf.ini'
46--- templates/kilo/ml2_conf.ini 2015-11-07 05:08:13 +0000
47+++ templates/kilo/ml2_conf.ini 2016-02-17 09:53:01 +0000
48@@ -20,7 +20,7 @@
49 tunnel_id_ranges = 1:1000
50
51 [ml2_type_vxlan]
52-vni_ranges = 1001:2000
53+vni_ranges = {{ vni_ranges }}
54
55 [ml2_type_vlan]
56 network_vlan_ranges = {{ vlan_ranges }}
57
58=== modified file 'unit_tests/test_neutron_api_context.py'
59--- unit_tests/test_neutron_api_context.py 2016-01-22 15:14:59 +0000
60+++ unit_tests/test_neutron_api_context.py 2016-02-17 09:53:01 +0000
61@@ -319,6 +319,7 @@
62 'quota_subnet': 10,
63 'quota_vip': 10,
64 'vlan_ranges': 'physnet1:1000:2000',
65+ 'vni_ranges': '1001:2000',
66 'enable_ml2_port_security': True
67 }
68 napi_ctxt = context.NeutronCCContext()
69@@ -354,6 +355,7 @@
70 'quota_subnet': 10,
71 'quota_vip': 10,
72 'vlan_ranges': 'physnet1:1000:2000',
73+ 'vni_ranges': '1001:2000',
74 'network_providers': 'physnet2,physnet3',
75 'enable_ml2_port_security': True
76 }
77@@ -395,6 +397,7 @@
78 'quota_subnet': 10,
79 'quota_vip': 10,
80 'vlan_ranges': 'physnet1:1000:2000',
81+ 'vni_ranges': '1001:2000',
82 'enable_ml2_port_security': True
83 }
84 napi_ctxt = context.NeutronCCContext()

Subscribers

People subscribed via source and target branches