Merge ~seyeongkim/charm-prometheus-openstack-exporter:hardcoded_prodstack5 into charm-prometheus-openstack-exporter:master

Proposed by Seyeong Kim
Status: Merged
Approved by: Eric Chen
Approved revision: 78aff107bc7dda22a1900d6e139e4bc5c2dad0ad
Merged at revision: 7be26bbada28bf3e9a13b7b3c3ed79ada0cb3395
Proposed branch: ~seyeongkim/charm-prometheus-openstack-exporter:hardcoded_prodstack5
Merge into: charm-prometheus-openstack-exporter:master
Diff against target: 15 lines (+2/-2)
1 file modified
src/templates/grafana-dashboards/overview-openstack-exporter-dashboard.json.j2 (+2/-2)
Reviewer Review Type Date Requested Status
Eric Chen Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Erhan Sunar (community) Approve
Review via email: mp+431551@code.launchpad.net

Commit message

Fixing hardcoded prodstack5 to RegionOne

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Erhan Sunar (esunar) wrote :

LGTM

review: Approve
Revision history for this message
Eric Chen (eric-chen) wrote :

Erhan, the jenkins is blocked. Could you please take a look ? thanks!

https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus-openstack-exporter-ci/

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7be26bbada28bf3e9a13b7b3c3ed79ada0cb3395

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/templates/grafana-dashboards/overview-openstack-exporter-dashboard.json.j2 b/src/templates/grafana-dashboards/overview-openstack-exporter-dashboard.json.j2
2index c621d44..2406f9b 100644
3--- a/src/templates/grafana-dashboards/overview-openstack-exporter-dashboard.json.j2
4+++ b/src/templates/grafana-dashboards/overview-openstack-exporter-dashboard.json.j2
5@@ -3843,8 +3843,8 @@
6 "allValue":null,
7 "current":{
8 "selected":false,
9- "text":"prodstack5",
10- "value":"prodstack5"
11+ "text":"RegionOne",
12+ "value":"RegionOne"
13 },
14 "datasource":"prometheus - Juju generated source",
15 "definition":"",

Subscribers

People subscribed via source and target branches

to all changes: