Merge lp:~sevoir/firefox-extensions/ubuntu-hu-menu.ubuntu into lp:~ubuntu-dev/firefox-extensions/ubuntu-hu-menu.ubuntu

Proposed by Alexander Sack on 2009-10-01
Status: Needs review
Proposed branch: lp:~sevoir/firefox-extensions/ubuntu-hu-menu.ubuntu
Merge into: lp:~ubuntu-dev/firefox-extensions/ubuntu-hu-menu.ubuntu
To merge this branch: bzr merge lp:~sevoir/firefox-extensions/ubuntu-hu-menu.ubuntu
Reviewer Review Type Date Requested Status
Benjamin Drung 2009-10-01 Abstain on 2009-10-07
Alexander Sack (community) Abstain on 2009-10-07
Review via email: mp+12718@code.launchpad.net
To post a comment you must log in.
Alexander Sack (asac) wrote :

requesting merge against empty ~ubuntu-dev branch so we can get review discussion here.

Alexander Sack (asac) wrote :

so obvious comment is that you didnt use med-xpi-unpack to produce your .upstream branch. in particular there must not be a .jar file etc. i will check more later.

review: Needs Fixing
11. By Szenográdi Norbert Péter on 2009-10-01

* unpacking jar file *

Szenográdi Norbert Péter (sevoir) wrote :

> so obvious comment is that you didnt use med-xpi-unpack to produce your
> .upstream branch. in particular there must not be a .jar file etc. i will
> check more later.

unpacked and uploaded.

Benjamin Drung (bdrung) wrote :

The same comments as for ubuntu-hu-menu:

* The source package should not contain xul-ext (simply call it ubuntu-hu-menu)
* The long description is a little bit short
* I recommend to use DEP-5 for the copyright file: http://dep.debian.net/deps/dep5/
* Remove the comments from the debian/rules file

Is MOZ_XPI_EMID really required? If it does not work without it, it is probably a bug in mozilla-devscripts.

review: Needs Fixing
Alexander Sack (asac) wrote :

Benjamin, maybe you can point sevoir to an example for dep5 copyright. i think reading through the whole spec is too much as most extensions probably have everything the same license, etc.

review: Abstain

Unmerged revisions

11. By Szenográdi Norbert Péter on 2009-10-01

* unpacking jar file *

10. By Szenográdi Norbert Péter on 2009-10-01

* jar file link correction *

9. By Szenográdi Norbert Péter on 2009-10-01

* debian/rules correction *

8. By Szenográdi Norbert Péter on 2009-10-01

* debian/rules correction *

7. By Szenográdi Norbert Péter on 2009-10-01

* jar file correction *

6. By Szenográdi Norbert Péter on 2009-10-01

* some editing *

5. By Szenográdi Norbert Péter on 2009-10-01

* tuttoolbar.jar correction *

4. By Szenográdi Norbert Péter on 2009-10-01

* editing debian/control *

3. By Szenográdi Norbert Péter on 2009-10-01

* editing debian/rules *

2. By Szenográdi Norbert Péter on 2009-10-01

* initial packaging based on XPI.TEMPLATE *

Updating diff...

An updated diff will be available in a few minutes. Reload to see the changes.

Subscribers

People subscribed via source and target branches