Merge lp:~sethj/ubuntu/wily/unity/fix-for-1445595 into lp:unity

Proposed by Seth Johnson
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~sethj/ubuntu/wily/unity/fix-for-1445595
Merge into: lp:unity
Diff against target: 26 lines (+7/-1)
2 files modified
debian/changelog (+7/-0)
unity-shared/GnomeFileManager.cpp (+0/-1)
To merge this branch: bzr merge lp:~sethj/ubuntu/wily/unity/fix-for-1445595
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Disapprove
Ubuntu branches Pending
Review via email: mp+276074@code.launchpad.net

Commit message

Don't open nautilus when the users empties the trash from the launcher. (LP: #1445595)

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Unfortunately this has the side effect of making the confirmation dialog not to be shown on top when focus stealing prevention is enabled.

In order to fix this properly, we should add a new method to nautilus to pass the event timestamp to it.

review: Disapprove

Unmerged revisions

4028. By Seth Johnson

Don't open nautilus when the user empties the trash from the launcher
(LP: #1445595)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-10-16 08:46:34 +0000
3+++ debian/changelog 2015-10-29 01:27:20 +0000
4@@ -1,3 +1,10 @@
5+unity (7.3.2+15.10.20151016-0ubuntu3) wily; urgency=medium
6+
7+ * Don't open nautilus when the user empties the trash from the launcher
8+ (LP: #1445595)
9+
10+ -- Seth Johnson <sethj0438@gmail.com> Wed, 28 Oct 2015 17:04:07 -0700
11+
12 unity (7.3.2+15.10.20151016-0ubuntu1) wily; urgency=medium
13
14 [ Marco Trevisan (Treviño) ]
15
16=== modified file 'unity-shared/GnomeFileManager.cpp'
17--- unity-shared/GnomeFileManager.cpp 2013-10-07 22:37:34 +0000
18+++ unity-shared/GnomeFileManager.cpp 2015-10-29 01:27:20 +0000
19@@ -213,7 +213,6 @@
20
21 void GnomeFileManager::EmptyTrash(uint64_t timestamp)
22 {
23- Activate(timestamp);
24 auto const& proxy = impl_->NautilusOperationsProxy();
25
26 // Passing the proxy to the lambda we ensure that it will be destroyed when needed