Merge ~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools:esm-chroot-names-2 into ubuntu-security-tools:master

Proposed by Spyros Seimenis
Status: Merged
Merged at revision: 311820e01773d10d69f9749c25ae3ced8b7539f7
Proposed branch: ~sespiros/ubuntu-security-tools/+git/ubuntu-security-tools:esm-chroot-names-2
Merge into: ubuntu-security-tools:master
Diff against target: 25 lines (+10/-2)
1 file modified
build-tools/umt (+10/-2)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+424692@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Spyros Seimenis (sespiros) wrote :
Revision history for this message
Alex Murray (alexmurray) wrote :

This looks like a good usability improvement since in general all packages published to ESM have 'esm' in the version and so should be built in ESM chroots.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/build-tools/umt b/build-tools/umt
2index 24beb0b..a2b8f9f 100755
3--- a/build-tools/umt
4+++ b/build-tools/umt
5@@ -637,10 +637,18 @@ def perform_binary_build(details, opt):
6 if opt.hardening:
7 extra_deps.append('hardening-wrapper')
8
9- details['chroot'] = "%s-i386" % details['release']
10+ chroot = details['release']
11+
12+ if 'esm' in details['version']:
13+ chroot += "-esm"
14+
15 (rc, arch) = runcmd(['uname', '-m'])
16 if arch.strip() == "x86_64":
17- details['chroot'] = "%s-amd64" % details['release']
18+ chroot += "-amd64"
19+ else:
20+ chroot += "-i386"
21+
22+ details['chroot'] = chroot
23
24 if opt.chroot:
25 details['chroot'] = opt.chroot

Subscribers

People subscribed via source and target branches