Odoo Server (MOVED TO GITHUB)

Merge lp:~serpent-consulting-services/openobject-server/6.1-928431-SerpentCS into lp:openobject-server

  1. 6.1-928431-SerpentCS
  2. Merge into trunk
Proposed by Serpent Consulting Services
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp:~serpent-consulting-services/openobject-server/6.1-928431-SerpentCS
Merge into: lp:openobject-server
Diff against target: 12 lines (+1/-1)
1 file modified
openerp/addons/base/module/module_view.xml (+1/-1)
To merge this branch: bzr merge lp:~serpent-consulting-services/openobject-server/6.1-928431-SerpentCS
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Review via email: mp+91905@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Hello,

I think it would be better to make the demo field readonly at the model level rather than the view, in order to make it global.

This was fixed at revision 4058 rev-id: <email address hidden>

Thanks!

review: Disapprove

Unmerged revisions

4009. By Serpent Consulting Services

[FIX] Base : 'Demo data' boolean on Modules should be readonly

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/module/module_view.xml'
2--- openerp/addons/base/module/module_view.xml 2011-12-30 14:56:07 +0000
3+++ openerp/addons/base/module/module_view.xml 2012-02-07 19:28:19 +0000
4@@ -127,7 +127,7 @@
5 <field name="certificate" />
6 <field name="category_id"/>
7 <field name="complexity"/>
8- <field name="demo"/>
9+ <field name="demo" readonly="1"/>
10 <field name="icon"/>
11 <field name="application"/>
12 </group>