Merge lp:~serpent-consulting-services/openobject-addons/7.0-sale_margin-1090931 into lp:openobject-addons
Proposed by
Serpent Consulting Services
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8400 | ||||
Proposed branch: | lp:~serpent-consulting-services/openobject-addons/7.0-sale_margin-1090931 | ||||
Merge into: | lp:openobject-addons | ||||
Diff against target: |
22 lines (+5/-2) 1 file modified
sale_margin/sale_margin.py (+5/-2) |
||||
To merge this branch: | bzr merge lp:~serpent-consulting-services/openobject-addons/7.0-sale_margin-1090931 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Dony (Odoo) | Approve | ||
Review via email: mp+140106@code.launchpad.net |
To post a comment you must log in.
Indeed, functions that are passed as arguments to stored triggers are plain functions and cannot use the inheritance system. It is possibly to do it by having a simple lambda function that calls self._the_ real_method, when inheriting it is really necessary. In that case only the trivial lambda needs to be repeated, and the original method can be overridden.
Let's keep it simple here, your patch does the job :-)
Thanks!