Merge lp:~serpent-consulting-services/magentoerpconnect/gekko-tek-995351 into lp:magentoerpconnect/oerp6.1-stable

Proposed by Kyle Waid
Status: Merged
Merged at revision: 637
Proposed branch: lp:~serpent-consulting-services/magentoerpconnect/gekko-tek-995351
Merge into: lp:magentoerpconnect/oerp6.1-stable
Diff against target: 47 lines (+9/-7)
1 file modified
magentoerpconnect/magerp_osv.py (+9/-7)
To merge this branch: bzr merge lp:~serpent-consulting-services/magentoerpconnect/gekko-tek-995351
Reviewer Review Type Date Requested Status
Sébastien BEAU - http://www.akretion.com Pending
Review via email: mp+106493@code.launchpad.net

Description of the change

Logger improvement

To post a comment you must log in.
Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

thanks for your contribution

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'magentoerpconnect/magerp_osv.py'
2--- magentoerpconnect/magerp_osv.py 2012-05-12 15:53:53 +0000
3+++ magentoerpconnect/magerp_osv.py 2012-05-19 17:00:25 +0000
4@@ -35,6 +35,8 @@
5 from base_external_referentials.decorator import open_report
6 from base_external_referentials.decorator import catch_error_in_report
7 import netsvc
8+import logging
9+_logger = logging.getLogger(__name__)
10
11 osv.osv.mag_transform_and_send_one_resource = osv.osv._transform_and_send_one_resource
12
13@@ -178,28 +180,28 @@
14 self.password = password
15 self.debug = debug
16 self.result = {}
17- self.logger = logger
18+ self.logger = logger or _logger
19
20
21 def connect(self):
22 if not self.location[-1] == '/':
23 self.location += '/'
24 if self.debug:
25- self.logger.info(_("Attempting connection with Settings:%s,%s,%s") % (self.location, self.username, self.password))
26+ self.logger.info("Attempting connection with Settings:%s,%s,%s" % (self.location, self.username, self.password))
27 self.ser = xmlrpclib.ServerProxy(self.location)
28 for sleep_time in [1, 3, 6]:
29 try:
30 self.session = self.ser.login(self.username, self.password)
31 if self.debug:
32- self.logger.info(_("Login Successful"))
33+ self.logger.info("Login Successful")
34 return True
35 except IOError, e:
36- self.logger.error(_("Error in connecting:%s") % (e))
37- self.logger.warning(_("Webservice Failure, sleeping %s second before next attempt") % (sleep_time))
38+ self.logger.error("Error in connecting:%s" % e)
39+ self.logger.warning("Webservice Failure, sleeping %s second before next attempt" % sleep_time)
40 time.sleep(sleep_time)
41 except Exception,e:
42- self.logger.error(_("Magento Connection"), netsvc.LOG_ERROR, _("Error in connecting:%s") % (e))
43- self.logger.warning(_("Webservice Failure, sleeping %s second before next attempt") % (sleep_time))
44+ self.logger.error("Magento Connection" + netsvc.LOG_ERROR + "Error in connecting:%s" % e)
45+ self.logger.warning("Webservice Failure, sleeping %s second before next attempt" % sleep_time)
46 time.sleep(sleep_time)
47 raise osv.except_osv(_('User Error'), _('Error when try to connect to magento, are your sure that your login is right? Did openerp can access to your magento?'))
48