Merge lp:~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource into lp:ubuntu/wily/ubuntu-core-config
Proposed by
Sergio Schvezov
on 2015-05-26
| Status: | Merged |
|---|---|
| Merged at revision: | 30 |
| Proposed branch: | lp:~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource |
| Merge into: | lp:ubuntu/wily/ubuntu-core-config |
| Prerequisite: | lp:~sergiusens/ubuntu/wily/ubuntu-core-config/frameworks-writable |
| Diff against target: |
21 lines (+9/-0) 2 files modified
debian/changelog (+6/-0) etc/cloud/cloud.cfg.d/99-snappy-azure.cfg (+3/-0) |
| To merge this branch: | bzr merge lp:~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Salveti | Needs Fixing on 2015-06-08 | ||
| Ben Howard (community) | 2015-05-27 | Approve on 2015-06-08 | |
| Michael Vogt | 2015-05-26 | Needs Information on 2015-05-27 | |
|
Review via email:
|
|||
To post a comment you must log in.
| Sergio Schvezov (sergiusens) wrote : | # |
On Wed, May 27, 2015 at 07:41:47AM -0000, Michael Vogt wrote:
> Review: Needs Information
>
> Thanks, this looks good. I added Ben to ensure nothing breaks if this gets merged on azure. Is there anything else that needs changing when this lands (does it obsoletes the azure device tarball for example?).
Yes it obsoletes the device tarball for azure, but that is a different
step ;-)
It also allows to remove python 2 from the seeds, but we can wait for
him to answer.
| Ben Howard (utlemming) wrote : | # |
+1.
The only part that keeps this from obsoleting the Azure device tarball is the lack of "rootdelay=300." But it does remove the need for WALinuxAgent as well as Python 2.
Looks good to me.
review:
Approve
| Ricardo Salveti (rsalveti) wrote : | # |
Needs merge with trunk and changelog update.
review:
Needs Fixing
lp:~sergiusens/ubuntu/wily/ubuntu-core-config/azure-datasource
updated
on 2015-07-01
- 23. By Sergio Schvezov on 2015-07-01
-
Merging trunk
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, this looks good. I added Ben to ensure nothing breaks if this gets merged on azure. Is there anything else that needs changing when this lands (does it obsoletes the azure device tarball for example?).