Merge lp:~sergiusens/ubuntu-terminal-app/clicker into lp:ubuntu-terminal-app

Proposed by Sergio Schvezov
Status: Merged
Approved by: Michael Hall
Approved revision: 28
Merged at revision: 26
Proposed branch: lp:~sergiusens/ubuntu-terminal-app/clicker
Merge into: lp:ubuntu-terminal-app
Diff against target: 95 lines (+31/-6)
4 files modified
apparmor/terminal.json (+4/-0)
manifest.json (+16/-0)
tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+10/-5)
ubuntu-terminal-app.qml (+1/-1)
To merge this branch: bzr merge lp:~sergiusens/ubuntu-terminal-app/clicker
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Review via email: mp+189578@code.launchpad.net

Commit message

Upstreaming click support

To post a comment you must log in.
27. By Sergio Schvezov

Fixing domain and pep8 issues in __init__.py for tests

28. By Sergio Schvezov

Fixing domain for terminal.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Looks good.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'apparmor'
2=== added file 'apparmor/terminal.json'
3--- apparmor/terminal.json 1970-01-01 00:00:00 +0000
4+++ apparmor/terminal.json 2013-10-08 10:12:15 +0000
5@@ -0,0 +1,4 @@
6+{
7+ "policy_version": 1.0,
8+ "template": "unconfined"
9+}
10\ No newline at end of file
11
12=== added file 'manifest.json'
13--- manifest.json 1970-01-01 00:00:00 +0000
14+++ manifest.json 2013-10-08 10:12:15 +0000
15@@ -0,0 +1,16 @@
16+{
17+ "architecture": "armhf",
18+ "description": "Terminal application",
19+ "framework": "ubuntu-sdk-13.10",
20+ "hooks": {
21+ "terminal": {
22+ "apparmor": "apparmor/terminal.json",
23+ "desktop": "ubuntu-terminal-app.desktop"
24+ }
25+ },
26+ "icon": "terminal64.png",
27+ "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>",
28+ "name": "com.ubuntu.terminal",
29+ "title": "terminal",
30+ "version": "0.5"
31+}
32
33=== modified file 'tests/autopilot/ubuntu_terminal_app/tests/__init__.py'
34--- tests/autopilot/ubuntu_terminal_app/tests/__init__.py 2013-10-03 17:23:45 +0000
35+++ tests/autopilot/ubuntu_terminal_app/tests/__init__.py 2013-10-08 10:12:15 +0000
36@@ -30,7 +30,8 @@
37 scenarios = [('with touch', dict(input_device_class=Touch))]
38
39 local_location = "../../ubuntu-terminal-app.qml"
40- installed_location = "/usr/share/ubuntu-terminal-app/ubuntu-terminal-app.qml"
41+ installed_location = \
42+ "/usr/share/ubuntu-terminal-app/ubuntu-terminal-app.qml"
43
44 def setUp(self):
45 self.pointing_device = Pointer(self.input_device_class.create())
46@@ -60,23 +61,28 @@
47 emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
48
49 def launch_test_click(self):
50- self.app = self.launch_click_package("com.ubuntu.ubuntu-terminal-app", emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
51+ self.app = self.launch_click_package(
52+ "com.ubuntu.terminal",
53+ emulator_base=toolkit_emulators.UbuntuUIToolkitEmulatorBase)
54
55 @property
56 def main_view(self):
57 return self.app.select_single(emulators.MainView)
58
59+
60 class DbMan(object):
61 """
62 Helper functions for dealing with sqlite databases
63 """
64
65 def get_db(self):
66- dbs_path = os.path.expanduser("~/.local/share/ubuntu-terminal-app/Databases")
67+ dbs_path = os.path.expanduser(
68+ "~/.local/share/com.ubuntu.terminal/Databases")
69 if not os.path.exists(dbs_path):
70 return None
71
72- files = [ f for f in os.listdir(dbs_path) if os.path.splitext(f)[1] == ".ini" ]
73+ files = [f for f in os.listdir(dbs_path)
74+ if os.path.splitext(f)[1] == ".ini"]
75 for f in files:
76 ini_path = os.path.join(dbs_path, f)
77 with open(ini_path) as ini:
78@@ -122,4 +128,3 @@
79 if row is None:
80 self.assertNotEquals(row, None)
81 return row[0]
82-
83
84=== modified file 'ubuntu-terminal-app.qml'
85--- ubuntu-terminal-app.qml 2013-08-08 22:51:33 +0000
86+++ ubuntu-terminal-app.qml 2013-10-08 10:12:15 +0000
87@@ -7,7 +7,7 @@
88 // objectName for functional testing purposes (autopilot-qt5)
89 id: mview
90 objectName: "terminal"
91- applicationName: "ubuntu-terminal-app"
92+ applicationName: "com.ubuntu.terminal"
93 automaticOrientation: true
94
95 width: units.gu(50)

Subscribers

People subscribed via source and target branches