Merge lp:~sergiusens/ubuntu-clock-app/icon into lp:ubuntu-clock-app/saucy

Proposed by Sergio Schvezov
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 349
Merged at revision: 348
Proposed branch: lp:~sergiusens/ubuntu-clock-app/icon
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 37 lines (+4/-3)
1 file modified
CMakeLists.txt (+4/-3)
To merge this branch: bzr merge lp:~sergiusens/ubuntu-clock-app/icon
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Clock Developers Pending
Review via email: mp+207295@code.launchpad.net

Commit message

icon install rule when using cmake

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-02-18 21:11:37 +0000
3+++ CMakeLists.txt 2014-02-19 21:06:02 +0000
4@@ -12,7 +12,7 @@
5 set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
6 set(APP_HARDCODE ubuntu-clock-app)
7 set(MAIN_QML ${APP_HARDCODE}.qml)
8-set(ICON clock-app@30.png)
9+set(ICON_FILE clock-app@30.png)
10 set(AUTOPILOT_DIR ubuntu_clock_app)
11
12 if(CLICK_MODE)
13@@ -23,13 +23,14 @@
14 set(CMAKE_INSTALL_PREFIX /)
15 set(CMAKE_INSTALL_BINDIR /)
16 set(DATA_DIR /)
17+ set(ICON ${ICON_FILE})
18 set(EXEC "qmlscene ${MAIN_QML}")
19 set(DESKTOP_DIR ${DATA_DIR})
20 set(URLS_DIR ${DATA_DIR})
21 else(CLICK_MODE)
22 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})
23 set(EXEC ${APP_HARDCODE})
24- set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON})
25+ set(ICON ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON_FILE})
26 configure_file(${APP_HARDCODE}.in
27 ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE})
28 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
29@@ -49,7 +50,7 @@
30 *.qml *.js *.png *.js)
31 install(DIRECTORY alarm clock common images stopwatch timer
32 DESTINATION ${DATA_DIR})
33-install(FILES ${MAIN_QML} DESTINATION ${DATA_DIR})
34+install(FILES ${MAIN_QML} ${ICON_FILE} DESTINATION ${DATA_DIR})
35
36 configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
37 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}

Subscribers

People subscribed via source and target branches