Merge lp:~sergiusens/snappy/tarmac into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Sergio Schvezov
Status: Merged
Merged at revision: 137
Proposed branch: lp:~sergiusens/snappy/tarmac
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 44 lines (+40/-0)
1 file modified
.tarmac.sh (+40/-0)
To merge this branch: bzr merge lp:~sergiusens/snappy/tarmac
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+248328@code.launchpad.net

Commit message

Adding .tarmac.sh for tarmac consumption.

Description of the change

If you approve this, tarmac will merge this automatically.

The rules for merging, which are not part of this MP are:
- top approval
- one vote for approval and no disapprovals

Until asac adds the tarmac user I created to ~snappy-dev, merges and merge comments will show my name.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0. Got: 1 Pending.

Revision history for this message
Michael Vogt (mvo) wrote :

Hi Sergio,

thanks a lot for doing this! This is great. I can add the tarmac user to ~snappy-dev. Please let me know what ID it has. I think we need to create a trello card that the tests needs to setup their own dbus (makes sense anyway) so that this is not forgotten.

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> Hi Sergio,
>
> thanks a lot for doing this! This is great. I can add the tarmac user to
> ~snappy-dev. Please let me know what ID it has. I think we need to create a
> trello card that the tests needs to setup their own dbus (makes sense anyway)
> so that this is not forgotten.

If I did everything right, the correct user should be used now to merge and comment.

The task has been added.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.tarmac.sh'
2--- .tarmac.sh 1970-01-01 00:00:00 +0000
3+++ .tarmac.sh 2015-02-03 00:53:51 +0000
4@@ -0,0 +1,40 @@
5+#!/bin/sh
6+
7+set -ev
8+
9+export GOPATH=$(mktemp -d)
10+trap 'rm -r "$GOPATH"' EXIT
11+
12+echo Checking formatting
13+fmt=$(gofmt -l .)
14+
15+if [ -n "$fmt" ]; then
16+ echo "Formatting wrong in following files"
17+ echo $fmt
18+ exit 1
19+fi
20+
21+echo Obtaining dependencies
22+go get -d -v launchpad.net/snappy/...
23+
24+# this is a hack, but not sure tarmac is golang friendly
25+rm -r $GOPATH/src/launchpad.net/snappy
26+mkdir $GOPATH/src/launchpad.net/snappy
27+
28+cp -r . $GOPATH/src/launchpad.net/snappy/
29+cd $GOPATH/src/launchpad.net/snappy
30+
31+echo Building
32+go build -v launchpad.net/snappy/...
33+
34+echo Obtaining test dependencies
35+go get gopkg.in/check.v1
36+
37+echo "Setting up dbus (the test is supposed to do this itself)"
38+dbus_output=$(dbus-daemon --print-address --session --print-pid --fork)
39+export DBUS_SESSION_BUS_ADDRESS=$(echo $dbus_output | awk '{print $1}')
40+export dbus_pid=$(echo $dbus_output | awk '{print $2}')
41+trap 'kill -9 "$dbus_pid"' EXIT
42+
43+echo Running tests from $(pwd)
44+go test ./...

Subscribers

People subscribed via source and target branches