Merge lp:~sergiusens/snappy/reviewNOT into lp:~snappy-dev/snappy/snappy-moved-to-github

Proposed by Sergio Schvezov
Status: Merged
Approved by: John Lenton
Approved revision: no longer in the source branch.
Merged at revision: 448
Proposed branch: lp:~sergiusens/snappy/reviewNOT
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 43 lines (+14/-12)
1 file modified
cmd/snappy/cmd_build.go (+14/-12)
To merge this branch: bzr merge lp:~sergiusens/snappy/reviewNOT
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+258530@code.launchpad.net

Commit message

Disabling review tools

To post a comment you must log in.
Revision history for this message
Alexander Sack (asac) wrote :

i am happy with the content of this change!

Revision history for this message
John Lenton (chipaca) :
review: Approve
lp:~sergiusens/snappy/reviewNOT updated
448. By Sergio Schvezov

Disabling review tools by sergiusens approved by chipaca

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmd/snappy/cmd_build.go'
2--- cmd/snappy/cmd_build.go 2015-04-20 10:40:12 +0000
3+++ cmd/snappy/cmd_build.go 2015-05-07 17:10:52 +0000
4@@ -19,8 +19,6 @@
5
6 import (
7 "fmt"
8- "os"
9- "os/exec"
10
11 "launchpad.net/snappy/snappy"
12 )
13@@ -53,16 +51,20 @@
14 return err
15 }
16
17- _, err = exec.LookPath(clickReview)
18- if err != nil {
19- fmt.Fprintf(os.Stderr, "Warning: could not review package (%s not available)\n", clickReview)
20- }
21-
22- cmd := exec.Command(clickReview, snapPackage)
23- cmd.Stdout = os.Stdout
24- cmd.Stderr = os.Stderr
25- // we ignore the error for now
26- _ = cmd.Run()
27+ /*
28+ Disabling review tools run until the output reflects reality more closely
29+
30+ _, err = exec.LookPath(clickReview)
31+ if err != nil {
32+ fmt.Fprintf(os.Stderr, "Warning: could not review package (%s not available)\n", clickReview)
33+ }
34+
35+ cmd := exec.Command(clickReview, snapPackage)
36+ cmd.Stdout = os.Stdout
37+ cmd.Stderr = os.Stderr
38+ // we ignore the error for now
39+ _ = cmd.Run()
40+ */
41
42 fmt.Printf("Generated '%s' snap\n", snapPackage)
43 return nil

Subscribers

People subscribed via source and target branches