Merge lp:~sergiusens/snappy/inhibitSystemCtl into lp:~snappy-dev/snappy/snappy-moved-to-github
Proposed by
Sergio Schvezov
Status: | Rejected |
---|---|
Rejected by: | Sergio Schvezov |
Proposed branch: | lp:~sergiusens/snappy/inhibitSystemCtl |
Merge into: | lp:~snappy-dev/snappy/snappy-moved-to-github |
Diff against target: |
49 lines (+8/-13) 2 files modified
snappy/click.go (+5/-7) snappy/click_test.go (+3/-6) |
To merge this branch: | bzr merge lp:~sergiusens/snappy/inhibitSystemCtl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Disapprove | ||
Michael Vogt (community) | Approve | ||
Review via email: mp+255290@code.launchpad.net |
Commit message
Inhibit systemctl completely on inhibithooks requests
Description of the change
The inhibit hooks flag was added for u-d-f, as such it is meant to use from clients on different systems; systemctl may not be available (it is not on the latest ubuntu lts), so we prefer to inhibit it completely and let the on boot hook run task (systemd unit) deal with the hook setup.
To post a comment you must log in.
Unmerged revisions
- 307. By Sergio Schvezov
-
Fixing tests:
- Check for len 0 for system hooks when inhibiting.
- Make it easier on editors that trim empty spaces. - 306. By Sergio Schvezov
-
systemctl not to be called with inhibithooks
We probably need the first-boot script support for this to land first, right? Or has this landed already?
Systemctl enable is actually just setting a symlink into /etc/systemd/ system/ multi-user. target. wants to the service file - I wonder if we should just do that. The risk is of course that if its doing systemctl is doing more at some point we need to adjust. So first boot might be better (if we can get it done in a clean way).