Merge lp:~sergiusens/snappy/failSooner into lp:~snappy-dev/snappy/snappy-moved-to-github

[Sergio Schvezov]

On tar unpack don't let an error slip away to deal with later.

Fail sooner on errors; this makes it easier to debug and troubleshoot and if the directory can't be created here, it will most likely fail to be created later anyways.

[John Lenton (chipaca)]

I don't think this branch does what you think it does.

review: Needs Information

[Sergio Schvezov (sergiusens)]

review: Disapprove

Unmerged revisions

289. By Sergio Schvezov on 2015-03-31

On tar unpack don't let an error slip away

=== modified file 'helpers/helpers.go'
--- helpers/helpers.go	2015-03-27 11:30:22 +0000
+++ helpers/helpers.go	2015-03-31 02:07:19 +0000
@@ -111,9 +111,8 @@
 		path := filepath.Join(targetDir, name)
 		info := hdr.FileInfo()
 		if info.IsDir() {
-			err := os.MkdirAll(path, info.Mode())
-			if err != nil {
-				return nil
+			if err := os.MkdirAll(path, info.Mode()); err != nil {
+				return err
 			}
 		} else {
 			err := os.MkdirAll(filepath.Dir(path), 0777)