Merge lp:~sergiusens/snappy/downloadIcon into lp:~snappy-dev/snappy/snappy-moved-to-github
Proposed by
Sergio Schvezov
Status: | Merged |
---|---|
Approved by: | John Lenton |
Approved revision: | 529 |
Merged at revision: | 534 |
Proposed branch: | lp:~sergiusens/snappy/downloadIcon |
Merge into: | lp:~snappy-dev/snappy/snappy-moved-to-github |
Prerequisite: | lp:~sergiusens/snappy/splitDown |
Diff against target: |
281 lines (+96/-19) 5 files modified
snappy/dirs.go (+5/-1) snappy/install_test.go (+19/-11) snappy/parts.go (+7/-0) snappy/snapp.go (+31/-0) snappy/snapp_test.go (+34/-7) |
To merge this branch: | bzr merge lp:~sergiusens/snappy/downloadIcon |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Lenton (community) | Approve | ||
Review via email: mp+263296@code.launchpad.net |
Commit message
Download store icon for package on install
Description of the change
This is in a directory on its own to later be able to publish the dir and export over http easily (webdm has immediate gains).
I'm not super convinced of the dirPath leaf name given that we may also consider downloading screenshots.
To post a comment you must log in.
modulo a nit