Snappy

Merge lp:~sergiusens/snappy/closeMe into lp:~snappy-dev/snappy/snappy-moved-to-github

  1. closeMe
  2. Merge into snappy-moved-to-github
Proposed by Sergio Schvezov
Status: Merged
Approved by: John Lenton
Approved revision: 562
Merged at revision: 562
Proposed branch: lp:~sergiusens/snappy/closeMe
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 19 lines (+2/-0)
1 file modified
snappy/snapp.go (+2/-0)
To merge this branch: bzr merge lp:~sergiusens/snappy/closeMe
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
John Lenton (community) Approve
Review via email: mp+263943@code.launchpad.net

Commit message

Close downloaded files

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

Good catch.

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote :

\o/

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snappy/snapp.go'
2--- snappy/snapp.go 2015-06-30 12:26:38 +0000
3+++ snappy/snapp.go 2015-07-06 17:21:16 +0000
4@@ -1509,6 +1509,7 @@
5 os.Remove(w.Name())
6 }
7 }()
8+ defer w.Close()
9
10 // try anonymous download first and fallback to authenticated
11 url := s.pkg.AnonDownloadURL
12@@ -1547,6 +1548,7 @@
13 if err != nil {
14 return err
15 }
16+ defer w.Close()
17
18 if err := download("icon for package", w, req, pbar); err != nil {
19 return err

Subscribers

People subscribed via source and target branches