Merge lp:~sergiusens/snappy/backportReviewNOT into lp:~snappy-dev/snappy/15.04-deprecated

[Sergio Schvezov]

Backport disablement of review tools

[John Lenton (chipaca)]

review: Approve

[Snappy Tarmac (snappydevtarmac)]

The attempt to merge lp:~sergiusens/snappy/backportReviewNOT into lp:snappy/15.04 failed. Below is the output from the failed tests.

Checking formatting
Installing godeps
Install golint
Obtaining dependencies
update code.google.com/p/go.crypto failed; trying to fetch newer version
update github.com/blakesmith/ar failed; trying to fetch newer version
code.google.com/p/go.crypto now at 69e2a90ed92d03812364aeb947b7068dc42e561e
update github.com/cheggaaa/pb failed; trying to fetch newer version
github.com/blakesmith/ar now at c9a977dd0cc1392b023382c7bfa5a22af8d3b730
update github.com/jessevdk/go-flags failed; trying to fetch newer version
github.com/cheggaaa/pb now at e8c7cc515bfde3e267957a3b110080ceed51354e
update github.com/juju/loggo failed; trying to fetch newer version
github.com/jessevdk/go-flags now at 15347ef417a300349807983f15af9e65cd2e1b3a
update github.com/mvo5/goconfigparser failed; trying to fetch newer version
github.com/juju/loggo now at 4c7cbce140ca070eeb59a28f4bf9507e511711f9
update gopkg.in/yaml.v2 failed; trying to fetch newer version
github.com/mvo5/goconfigparser now at 26426272dda20cc76aa1fa44286dc743d2972fe8
update launchpad.net/gocheck failed; trying to fetch newer version
gopkg.in/yaml.v2 now at 49c95bdc21843256fb6c4e0d370a05f24a0bf213
launchpad.net/gocheck now at <email address hidden>
Building
Running tests from /tmp/tmp.TGky9uJAEX/src/launchpad.net/snappy
=== RUN Test
OK: 8 passed
--- PASS: Test (0.89 seconds)
PASS
coverage: 79.9% of statements
ok launchpad.net/snappy/clickdeb 0.904s coverage: 79.9% of statements
FAIL launchpad.net/snappy/cmd/snappy [build failed]
=== RUN Test
OK: 24 passed
--- PASS: Test (0.15 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/coreconfig 0.159s coverage: 100.0% of statements
=== RUN Test
OK: 30 passed
--- PASS: Test (1.64 seconds)
PASS
coverage: 80.3% of statements
ok launchpad.net/snappy/helpers 1.653s coverage: 80.3% of statements
=== RUN Test
OK: 7 passed
--- PASS: Test (0.10 seconds)
PASS
coverage: 92.5% of statements
ok launchpad.net/snappy/logger 0.113s coverage: 92.5% of statements
=== RUN Test
OK: 36 passed
--- PASS: Test (0.29 seconds)
PASS
coverage: 81.5% of statements
ok launchpad.net/snappy/partition 0.305s coverage: 81.5% of statements
=== RUN Test
OK: 12 passed
--- PASS: Test (0.22 seconds)
PASS
coverage: 87.8% of statements
ok launchpad.net/snappy/policy 0.250s coverage: 87.8% of statements
=== RUN Test
OK: 3 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 84.8% of statements
ok launchpad.net/snappy/priv 0.009s coverage: 84.8% of statements
=== RUN Test
OK: 4 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 50.0% of statements
ok launchpad.net/snappy/progress 0.040s coverage: 50.0% of statements
=== RUN Test
OK: 6 passed
--- PASS: Test (0.01 seconds)
PASS
coverage: 100.0% of statements
ok launchpad.net/snappy/release 0.020s coverage: 100.0% of statements
=== RUN Test
2015-05-07 20:43:52 ERROR snappy logger.go:199 hello-app.potato failed to install: a package by that name is already installed
2015-05-07 20:43:52 ERROR snappy logger.go:199 foo failed to install: the given snap is already installed
f...

=== modified file 'cmd/snappy/cmd_build.go'
--- cmd/snappy/cmd_build.go	2015-04-20 10:40:12 +0000
+++ cmd/snappy/cmd_build.go	2015-05-07 21:10:59 +0000
@@ -19,8 +19,6 @@
 
 import (
 	"fmt"
-	"os"
-	"os/exec"
 
 	"launchpad.net/snappy/snappy"
 )
@@ -53,16 +51,20 @@
 		return err
 	}
 
-	_, err = exec.LookPath(clickReview)
-	if err != nil {
-		fmt.Fprintf(os.Stderr, "Warning: could not review package (%s not available)\n", clickReview)
-	}
-
-	cmd := exec.Command(clickReview, snapPackage)
-	cmd.Stdout = os.Stdout
-	cmd.Stderr = os.Stderr
-	// we ignore the error for now
-	_ = cmd.Run()
+	/*
+		Disabling review tools run until the output reflects reality more closely
+
+		_, err = exec.LookPath(clickReview)
+		if err != nil {
+			fmt.Fprintf(os.Stderr, "Warning: could not review package (%s not available)\n", clickReview)
+		}
+
+		cmd := exec.Command(clickReview, snapPackage)
+		cmd.Stdout = os.Stdout
+		cmd.Stderr = os.Stderr
+		// we ignore the error for now
+		_ = cmd.Run()
+	*/
 
 	fmt.Printf("Generated '%s' snap\n", snapPackage)
 	return nil