Merge lp:~sergiusens/snapcraft/tested_or_not into lp:~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov on 2015-10-16
Status: Needs review
Proposed branch: lp:~sergiusens/snapcraft/tested_or_not
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 12 lines (+1/-1)
1 file modified
runtests.sh (+1/-1)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/tested_or_not
Reviewer Review Type Date Requested Status
Leo Arias (community) 2015-10-16 Needs Information on 2015-10-16
Review via email: mp+274741@code.launchpad.net

Commit message

Only run python3-coverage on tested code and not the tests themselves

To post a comment you must log in.
Leo Arias (elopio) wrote :

<elopio> sergiusens: why is that needed? I find it good to see if all your test code is being run.
<elopio> if it isn't, you can probably remove it. Or you have a condition that has to be faked.

review: Needs Information

Unmerged revisions

242. By Sergio Schvezov on 2015-10-16

Only run python3-coverage on tested code and not the tests themselves

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'runtests.sh'
2--- runtests.sh 2015-10-02 14:28:48 +0000
3+++ runtests.sh 2015-10-16 17:04:33 +0000
4@@ -68,7 +68,7 @@
5
6 if which python3-coverage >/dev/null 2>&1; then
7 python3-coverage erase
8- python3-coverage run --branch --source snapcraft -m unittest
9+ python3-coverage run --branch --source snapcraft --omit 'snapcraft/tests/*' -m unittest
10 mv .coverage .coverage.unit
11 else
12 python3 -m unittest

Subscribers

People subscribed via source and target branches