Snapcraft

Merge lp:~sergiusens/snapcraft/no-test-print into lp:~snappy-dev/snapcraft/core

  1. no-test-print
  2. Merge into core
Proposed by Sergio Schvezov on 2015-09-23
Status: Merged
Approved by: Federico Gimenez on 2015-09-23
Approved revision: 203
Merged at revision: 203
Proposed branch: lp:~sergiusens/snapcraft/no-test-print
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 13 lines (+0/-3)
1 file modified
snapcraft/tests/test_repo.py (+0/-3)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/no-test-print
Reviewer Review Type Date Requested Status
Federico Gimenez (community) 2015-09-23 Approve on 2015-09-23
Review via email: mp+272099@code.launchpad.net

Commit Message

do NOT print in tests

To post a comment you must log in.
Federico Gimenez (fgimenez) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snapcraft/tests/test_repo.py'
2--- snapcraft/tests/test_repo.py 2015-09-21 20:44:56 +0000
3+++ snapcraft/tests/test_repo.py 2015-09-23 13:05:03 +0000
4@@ -61,9 +61,6 @@
5 self.assertEqual(sources_list, expected_sources_list)
6 self.assertFalse(mock_cc.called)
7
8- print()
9- print(sources_list)
10-
11 def test_fix_symlinks(self):
12 tempdirObj = tempfile.TemporaryDirectory()
13 self.addCleanup(tempdirObj.cleanup)

Subscribers

People subscribed via source and target branches