Merge lp:~sergiusens/snapcraft/config into lp:~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov on 2015-09-20
Status: Merged
Approved by: Sergio Schvezov on 2015-09-21
Approved revision: 184
Merged at revision: 184
Proposed branch: lp:~sergiusens/snapcraft/config
Merge into: lp:~snappy-dev/snapcraft/core
Diff against target: 38 lines (+3/-3)
3 files modified
examples/webcam-webui/snapcraft.yaml (+1/-1)
integration-tests/data/pypi-config/snapcraft.yaml (+1/-1)
integration-tests/units/jobs.pxu (+1/-1)
To merge this branch: bzr merge lp:~sergiusens/snapcraft/config
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve on 2015-09-21
Daniel Holbach (community) Approve on 2015-09-21
Review via email: mp+271752@code.launchpad.net

Commit Message

Config hook examples update

To post a comment you must log in.
Daniel Holbach (dholbach) wrote :

Looks good!

review: Approve
Sergio Schvezov (sergiusens) wrote :

yay, dholbach needs to be in the snappy-dev team ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/webcam-webui/snapcraft.yaml'
2--- examples/webcam-webui/snapcraft.yaml 2015-09-17 06:24:37 +0000
3+++ examples/webcam-webui/snapcraft.yaml 2015-09-20 14:35:06 +0000
4@@ -7,7 +7,7 @@
5 services:
6 - name: webcam-webui
7 start: bin/webcam-webui
8-config: python3 usr/bin/config.py
9+config: usr/bin/config.py
10
11 parts:
12 cam:
13
14=== modified file 'integration-tests/data/pypi-config/snapcraft.yaml'
15--- integration-tests/data/pypi-config/snapcraft.yaml 2015-09-17 20:21:43 +0000
16+++ integration-tests/data/pypi-config/snapcraft.yaml 2015-09-20 14:35:06 +0000
17@@ -8,7 +8,7 @@
18
19 This package will download its dependencies from pypi.
20 icon: icon.png
21-config: python3 usr/bin/config.py
22+config: usr/bin/config.py
23
24 parts:
25 config:
26
27=== modified file 'integration-tests/units/jobs.pxu'
28--- integration-tests/units/jobs.pxu 2015-09-18 19:06:34 +0000
29+++ integration-tests/units/jobs.pxu 2015-09-20 14:35:06 +0000
30@@ -93,7 +93,7 @@
31 test -f ./snap/usr/bin/config.py
32 test -f ./snap/usr/bin/python3
33 test -f ./snap/meta/hooks/config
34- grep -q 'exec "python3" usr/bin/config.py $*' ./snap/meta/hooks/config
35+ grep -q 'exec "usr/bin/config.py" $*' ./snap/meta/hooks/config
36
37 id: snapcraft/normal/simple-make
38 plugin: shell

Subscribers

People subscribed via source and target branches