Merge lp:~sergiusens/snapcraft/1500758 into lp:~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
on 2015-09-29
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | John Lenton on 2015-09-29 | ||||
| Approved revision: | 216 | ||||
| Merged at revision: | 215 | ||||
| Proposed branch: | lp:~sergiusens/snapcraft/1500758 | ||||
| Merge into: | lp:~snappy-dev/snapcraft/core | ||||
| Diff against target: |
95 lines (+69/-0) 5 files modified
integration-tests/data/simple-scons/SConstruct (+14/-0) integration-tests/data/simple-scons/main.c (+5/-0) integration-tests/data/simple-scons/snapcraft.yaml (+11/-0) plugins/scons-project.yaml (+8/-0) snapcraft/plugins/scons_project.py (+31/-0) |
||||
| To merge this branch: | bzr merge lp:~sergiusens/snapcraft/1500758 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton | Approve on 2015-09-29 | ||
| Daniel Holbach | 2015-09-29 | Pending | |
|
Review via email:
|
|||
Commit Message
Adding a simple scons plugin
To post a comment you must log in.
| John Lenton (chipaca) wrote : | # |
review:
Approve


LGTM. Just one question.